Support "/"-prefixed prioritized files #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Dec 19, 2020
estargz/estargz.go
Outdated
| if strings.HasPrefix(name, "./") { | ||
| return strings.TrimPrefix(name, "./") | ||
| } | ||
| return name |
Member
There was a problem hiding this comment.
What happens for ../foo/bar (when consuming a tar archive created by other program)
Since this commit, WithPrioritiedFiles option accepts absolute paths and paths that rellative to root (e.g. paths prefixed with "./"). The input tar can include files that are relative to root (e.g. prefixed with "./"). So, in this commit, the specified prioritized file paths are normalized (using filepath.Clean()) and are compared against normalized tar entry names. Signed-off-by: Kohei Tokunaga <[email protected]>
AkihiroSuda
approved these changes
Dec 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
google/go-containerregistry#879 (comment)
Since this commit, WithPrioritiedFiles option accepts "/"-prefixed prioritied
files. It's also accepted that file entreis in the input tar are prefixed by
"./" or "/".
This should be merged after #212 is merged and conflicts are resolved.
cc @AkihiroSuda @mattmoor