[Carry 1948] fs/remote: Refactor blob code to make it more modular #1955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the blob handling code to improve code organization. The changes include: 1. Extract chunk handling logic into separate functions: - prepareChunksForRead: Prepare chunks for reading - readFromCache: Handle cache reading - cacheChunkData: Handle chunk caching - handleSharedFetch: Handle shared fetch scenarios - copyFetchedChunks: Copy fetched chunks 2. Improve error handling: - Add more descriptive error messages - Consistent error wrapping using fmt.Errorf - Maintain same error handling behavior 3. Keep original behavior: - Maintain same data flow - Keep same concurrency control - No additional memory allocations - Same caching mechanism 4. Code organization improvements: - Single responsibility functions - Clear function names - Better code readability - Easier to maintain and test Signed-off-by: ChengyuZhu6 <[email protected]>
Signed-off-by: Kohei Tokunaga <[email protected]>
AkihiroSuda
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1948
Thanks @ChengyuZhu6 for the refactoring patch, I'm going to merge that here with adding a tiny fix.