Make estargz lib importable independently #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Dec 14, 2020
| limitations under the License. | ||
| */ | ||
|
|
||
| package estargz |
Member
There was a problem hiding this comment.
I don't like this self copy in vendor dir. Can we remove vendor directory entirely?
Member
|
cc @mattmoor PTAL |
This enables to import estargz without extra dependencies from the snapshotter & ctr-remote. From this commit, estargz lib is handled as an independent package separated from stargz snapshotter. Currently, estargz lib isn't remotely importable so stargz snapshotter directly uses the local estargz lib with `replace` directive. Thus stargz snapshotter refers to the estargz lib contained in the same commit. Once estargz lib starts its own release lifecycle (i.e. starts to have its own version separated from stargz snapshotter), we can switch to import that released version if needed. Signed-off-by: Kohei Tokunaga <[email protected]>
Contributor
|
Awesome! |
AkihiroSuda
approved these changes
Dec 14, 2020
Member
🤣 |
AkihiroSuda
added a commit
to AkihiroSuda/buildkit_poc
that referenced
this pull request
Dec 18, 2020
The git repo of github.com/containerd/stargz-snapshotter now has two go.mod modules: - github.com/containerd/stargz-snapshotter - github.com/containerd/stargz-snapshotter/estargz So we need to have the following `replace` directive in `go.mod`: ``` github.com/containerd/stargz-snapshotter/estargz => github.com/containerd/stargz-snapshotter/estargz <VERSION> ``` Otherwise `go mod tidy` fails with the following error: ``` go: github.com/containerd/[email protected] requires github.com/containerd/stargz-snapshotter/[email protected]: invalid version: unknown revision 000000000000 ``` ref: containerd/stargz-snapshotter#195 Signed-off-by: Akihiro Suda <[email protected]>
alexcb
pushed a commit
to alexcb/buildkit
that referenced
this pull request
Jan 20, 2021
The git repo of github.com/containerd/stargz-snapshotter now has two go.mod modules: - github.com/containerd/stargz-snapshotter - github.com/containerd/stargz-snapshotter/estargz So we need to have the following `replace` directive in `go.mod`: ``` github.com/containerd/stargz-snapshotter/estargz => github.com/containerd/stargz-snapshotter/estargz <VERSION> ``` Otherwise `go mod tidy` fails with the following error: ``` go: github.com/containerd/[email protected] requires github.com/containerd/stargz-snapshotter/[email protected]: invalid version: unknown revision 000000000000 ``` ref: containerd/stargz-snapshotter#195 Signed-off-by: Akihiro Suda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#194
This enables to import estargz without extra dependencies from the snapshotter &
ctr-remote by adding
go.modtoestargzpackage.From this commit, estargz lib is handled as an independent package separated from stargz snapshotter.
Currently, estargz lib isn't remotely importable so stargz snapshotter directly
uses the local estargz lib with
replacedirective. Thus stargz snapshotterrefers to the estargz lib contained in the same commit.
Once estargz lib starts its own release lifecycle (i.e. starts to have its own
version separated from stargz snapshotter), we can switch to import that
released version if needed.