Add an option to ignore context canceled. #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktock
reviewed
Dec 10, 2020
cmd/ctr-remote/sampler/sampler.go
Outdated
| case <-sc: | ||
| log.G(ctx).Info("signal detected") | ||
| if ignoreCtxCancel { | ||
| log.G(ctx).Debugf("press Ctrl+C to terminate the container %q", id) |
Member
There was a problem hiding this comment.
Can we make it Infof? This information seems important for user.
So I want to run the container a bit longer until it finishes all the work for optimization. This option allows the container to wait until a keyboard signal (`Ctrl-C`) or a signal from other programs. Added this option to `ctr-remote i optimize` command: ``` --wait-on-signal ignore context cancel and keep the container running until it receives signal (Ctrl + C) sent manually ``` Signed-off-by: Jun Lin Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I want to run the container a bit longer until it finishes all the
work for optimization. This option allows the container to wait until a
keyboard signal (
Ctrl-C) or a signal from other programs.Added this option to
ctr-remote i optimizecommand:Signed-off-by: Jun Lin Chen [email protected]