-
Notifications
You must be signed in to change notification settings - Fork 49
Add klihub as committer #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Mike Brown <[email protected]>
mxpv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Welcome!
kzys
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome!
|
👍 to welcome Krisztian as a Committer of NRI, but maybe we want to see more engagement in the core repository from him to be a Core Committer |
A very valid and undeniable point and understandable sentiment. |
|
Agreed there is a governance issue we should address here first. Opened #148 as an attempt to solve it. I think it is fair to assume core committers have a dual responsibility of maintaining the core We can consider it again later, but I do think Krisztian is a good candidate as a core committer and there is value having representation from subprojects in the governance of the wider containerd project. |
|
SGTM for adding maintainer files to particular core subprojects |
|
containerd/nri#184 is merged and access is updated there |
Krisztian Litkey comes to us with a deep background in embedded and middleware. He works on Open Source Software for the Intel Data Center and Artificial Intelligence, System Software Engineering Group in Finland, focusing on Kubernetes and the Cloud Infrastructure.
Krisztian is a very active containerd contributor. He's been working with us for roughly three years now on a full redesign for how resource management will be implemented across sig-node components. He took the ball and ran with it doing most of the coding work for NRI's draft versions and any changes needed to containerd/cri-o and it was a big change to both containerd/ and containerd/NRI. He presents the NRI project at various OSS events and is also doing good things for the stack relative to the CNCF container orchestrated device project, DRA workgroups, and OCI.
Krisztian's resource management contributions range over the containerd/NRI project itself; additional NRI plugins found in containers/nri-plugins; various other resource related SIG-Node projects; and the container runtime implementation details in both containerd/containerd and cri-o/cri-o. Krisztian is also helping to champion NRI as a common plugin model for all container runtimes, noting he is also a reviewer in cri-o.
7 committer LGTM required (2/3 of 10 committers) + new committer