Fix a bug and add corresponding unit tests - #355
Merged
Conversation
added 3 commits
November 29, 2024 15:57
If an incremental layer contains a directory but the same path in the base layer is a non-directory, it will fail unexpectedly. This patch fixes it. Signed-off-by: Hongzhen Luo <hongzhen@linux.alibaba.com>
Currently, ErofsFile did not support pread(), this patch addresses this deficiency. Subsequent unit tests will be added accordingly. Signed-off-by: Hongzhen Luo <hongzhen@linux.alibaba.com>
Add unit tests for building images in clean and incremental modes. Signed-off-by: Hongzhen Luo <hongzhen@linux.alibaba.com>
hsiangkao
approved these changes
Dec 2, 2024
Member
|
Thanks～ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Not a directoryerror for incremental builds;E2E tests passed.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Please check the following list: