Skip to content

[Fix] access deleted point in prefetch thread. - #343

Merged
BigVan merged 1 commit into
containerd:mainfrom
BigVan:fix_prefetch
Aug 8, 2024
Merged

[Fix] access deleted point in prefetch thread.#343
BigVan merged 1 commit into
containerd:mainfrom
BigVan:fix_prefetch

Conversation

@BigVan

@BigVan BigVan commented Aug 8, 2024

Copy link
Copy Markdown
Member

What this PR does / why we need it:

The DynamicPrefetcher::replay(IFile* imgfile) progress is running in a background thread and it will access an invalid pointer after *imgfile has been deleted in stack_files()

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Signed-off-by: Yifan Yuan <tuji.yyf@alibaba-inc.com>
@BigVan
BigVan merged commit 1059cf4 into containerd:main Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant