Skip to content

[feat.] minor changes. - #329

Merged
liulanzheng merged 1 commit into
containerd:mainfrom
BigVan:main
May 13, 2024
Merged

[feat.] minor changes.#329
liulanzheng merged 1 commit into
containerd:mainfrom
BigVan:main

Conversation

@BigVan

@BigVan BigVan commented May 11, 2024

Copy link
Copy Markdown
Member
  • add version number in binary
  • skip background download if 'dir' didn't set in config.v1.json

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@BigVan BigVan changed the title [feat.] minor changes: [feat.] minor changes. May 11, 2024
  - add version number in binary
  - skip background download if 'dir' didn't set in config.v1.json

Signed-off-by: Yifan Yuan <tuji.yyf@alibaba-inc.com>

@liulanzheng liulanzheng left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liulanzheng
liulanzheng merged commit 73f9008 into containerd:main May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants