Skip to content

Fix build on Arch Linux - #315

Merged
liulanzheng merged 1 commit into
containerd:mainfrom
benwaffle:fix-build
Feb 26, 2024
Merged

Fix build on Arch Linux#315
liulanzheng merged 1 commit into
containerd:mainfrom
benwaffle:fix-build

Conversation

@benwaffle

Copy link
Copy Markdown

What this PR does / why we need it: Fixes a compilation error I get when building on Arch Linux. The numeric types (e.g. uint64_t) are defined in <cstdint> and the header file needs to be included.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@liulanzheng

Copy link
Copy Markdown
Member

@benwaffle Thank you. Could you mind to use git commit -s --amend --no-edit to sign your name and repush it?

Signed-off-by: Ben Iofel <bi@fly.io>
@benwaffle

Copy link
Copy Markdown
Author

@liulanzheng done

@liulanzheng liulanzheng left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liulanzheng
liulanzheng merged commit bcb8f21 into containerd:main Feb 26, 2024
@benwaffle
benwaffle deleted the fix-build branch February 27, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants