Skip to content

add mkfs for extfs and overlaybd-apply - #213

Merged
yuchen0cc merged 1 commit into
containerd:mainfrom
liulanzheng:main
May 11, 2023
Merged

add mkfs for extfs and overlaybd-apply#213
yuchen0cc merged 1 commit into
containerd:mainfrom
liulanzheng:main

Conversation

@liulanzheng

@liulanzheng liulanzheng commented May 11, 2023

Copy link
Copy Markdown
Member

What this PR does / why we need it:

add mkfs for extfs and overlaybd-apply/create

  • add a simple mkfs implementation with specific parameters
  • produce reproducible result with fixed uuid and hash seed
  • add --mkfs flag for overlaybd-apply/create, which do mkfs before apply data / after create

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Comment thread src/overlaybd/extfs/extfs.h Outdated
Comment thread src/tools/overlaybd-apply.cpp
Signed-off-by: liulanzheng <lanzheng.liulz@alibaba-inc.com>

@yuchen0cc yuchen0cc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuchen0cc
yuchen0cc merged commit 67b712b into containerd:main May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants