fix: retry fscache blob cull until cachefiles completes - #787
Open
Park-Jiyeonn wants to merge 1 commit into
Open
fix: retry fscache blob cull until cachefiles completes#787Park-Jiyeonn wants to merge 1 commit into
Park-Jiyeonn wants to merge 1 commit into
Conversation
6 tasks
Use nydusd's cull completion status during fscache teardown, and keep snapshot teardown state and blob metadata until cachefiles confirms reclamation. Unmount EROFS before unbinding and culling, and make retries tolerate an already-unmounted mountpoint. Return a pending error without dropping the teardown marker when cull is incomplete. Coordinate blob metadata publication with cache GC through a per-blob lifecycle. Skip a GC claim that overlaps a mount publication so a new mount cannot race with metadata removal. Add client, teardown, pending-cull, and publication/GC lifecycle tests. Signed-off-by: Park.Jiyeon <jiyeonnn2@icloud.com>
Park-Jiyeonn
force-pushed
the
fix/fscache-cull
branch
from
July 24, 2026 10:32
e76ce66 to
5e2024a
Compare
Contributor
Author
|
@Zephyrcf PTAL, thx! |
Collaborator
|
Two blockers as it stands:
Separately — this is 1200+ lines doing at least four independent things: the new cull client API, the umount/unbind reordering in Also note |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Use nydusd's cull completion status during fscache teardown, and keep snapshot teardown state and blob metadata until cachefiles confirms reclamation.
Unmount EROFS before unbinding and culling, and make retries tolerate an already-unmounted mountpoint. Return a pending error without dropping the teardown marker when cull is incomplete.
Coordinate blob metadata publication with cache GC through a per-blob lifecycle. Skip a GC claim that overlaps a mount publication so a new mount cannot race with metadata removal.
Add client, teardown, pending-cull, and publication/GC lifecycle tests.
Related: Nydusd: fix: report fscache blob cull completion status #1993
Change Type
Please select the type of change your pull request relates to: