fix(supervisor): manage received file descriptor ownership - #783
Open
Park-Jiyeonn wants to merge 1 commit into
Open
fix(supervisor): manage received file descriptor ownership#783Park-Jiyeonn wants to merge 1 commit into
Park-Jiyeonn wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #783 +/- ##
==========================================
- Coverage 26.01% 25.84% -0.17%
==========================================
Files 133 134 +1
Lines 12711 12833 +122
==========================================
+ Hits 3307 3317 +10
- Misses 8998 9110 +112
Partials 406 406
🚀 New features to boost your workflow:
|
Zephyrcf
reviewed
Jul 23, 2026
| } | ||
| } | ||
|
|
||
| func recv(uc *net.UnixConn) (data []byte, fd int, retErr error) { |
Contributor
There was a problem hiding this comment.
A small suggestion: unify the return value of fd for error paths in recv to fd (default value -1).
Close superseded state file descriptors and release descriptors received on invalid SCM_RIGHTS messages. Validate control-message truncation and require exactly one descriptor so malformed state transfers cannot leak resources or leave ambiguous ownership. Signed-off-by: Park.Jiyeon <jiyeonnn2@icloud.com>
Park-Jiyeonn
force-pushed
the
fix/supervisor-fd-lifecycle
branch
from
July 23, 2026 07:25
32b4ed7 to
6d5836d
Compare
Contributor
Author
|
@Zephyrcf If there are no further concerns, could this be merged when convenient? |
Collaborator
|
Thanks for the PR! Maybe there is a race between |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Close superseded state file descriptors and release descriptors received on invalid SCM_RIGHTS messages. Validate control-message truncation and require exactly one descriptor so malformed state transfers cannot leak resources or leave ambiguous ownership.
Change Type
Please select the type of change your pull request relates to: