Skip to content

api: generate field ownership functions #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samuelkarp wants to merge 2 commits into
base: main
Choose a base branch
from
Open

api: generate field ownership functions #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fec0cf
api: generate field ownership functions
samuelkarp Jan 15, 2026
13d8f93
api: deprecate Hooks funcs in favor of OciHooks
samuelkarp Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,12 +80,15 @@ FORCE:
# build targets
#

build-proto: check-protoc install-ttrpc-plugin install-wasm-plugin install-protoc-dependencies build-protoc-gen-strip
build-proto: check-protoc install-ttrpc-plugin install-wasm-plugin install-protoc-dependencies build-protoc-gen-strip build-protoc-gen-owners
for src in $(PROTO_SOURCES); do \
$(PROTO_COMPILE) \
--plugin=protoc-gen-strip=$(abspath $(BIN_PATH)/protoc-gen-strip) \
--strip_out=pkg/api \
--strip_opt=file=strip.go \
--plugin=protoc-gen-owners=$(abspath $(BIN_PATH)/protoc-gen-owners) \
--owners_out=pkg/api \
--owners_opt=file=owners_generated.go \
$$src; \
done
sed -i '1s;^;//go:build !wasip1\n\n;' pkg/api/api_ttrpc.pb.go
Expand Down Expand Up @@ -120,6 +123,11 @@ clean-cache:
# plugins build targets
#

.PHONY: build-protoc-gen-owners
build-protoc-gen-owners:
$(Q)echo "Building build/bin/protoc-gen-owners..."; \
$(GO_BUILD) -C tools/protoc-gen-owners -o $(abspath $(BIN_PATH)/protoc-gen-owners) $(GO_BUILD_FLAGS) .

.PHONY: build-protoc-gen-strip
build-protoc-gen-strip:
$(Q)echo "Building build/bin/protoc-gen-strip..."; \
Expand Down
2 changes: 1 addition & 1 deletion pkg/adaptation/result.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -714,7 +714,7 @@ func (r *result) adjustHooks(hooks *Hooks, plugin string) error {
}

if claim {
r.owners.ClaimHooks(container.Id, plugin)
r.owners.ClaimOciHooks(container.Id, plugin)
}

return nil
Expand Down
Loading
Loading