Skip to content
This repository was archived by the owner on Mar 9, 2022. It is now read-only.

Upgrade containerd to 8ed1e24ae925b5c6d8195858ee89dddb0507d65f #81

Merged
Random-Liu merged 2 commits into from
Jun 19, 2017
Merged

Upgrade containerd to 8ed1e24ae925b5c6d8195858ee89dddb0507d65f #81

Random-Liu merged 2 commits into from
Jun 19, 2017

Conversation

@Random-Liu
Copy link
Member

@Random-Liu Random-Liu commented Jun 19, 2017 •
edited
Loading

Upgrade containerd to containerd/containerd@8ed1e24 to add schema1 image support.

The schema1 image code is copied from containerd/containerd#968, won't need the code after switching to new containerd client.

@Random-Liu
Copy link
Member Author

Random-Liu commented Jun 19, 2017 •
edited
Loading

With this PR and #80, we can run node e2e test now. Here is the current node conformance test result:

Summarizing 6 Failures:

[Fail] [k8s.io] Networking [k8s.io] Granular Checks: Pods [It] should function for intra-pod communication: udp [Conformance] 
/home/lantaol/workspace/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/framework/networking_utils.go:217

[Fail] [k8s.io] Networking [k8s.io] Granular Checks: Pods [It] should function for node-pod communication: http [Conformance] 
/home/lantaol/workspace/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/framework/networking_utils.go:273

[Fail] [k8s.io] Networking [k8s.io] Granular Checks: Pods [It] should function for node-pod communication: udp [Conformance] 
/home/lantaol/workspace/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/framework/networking_utils.go:273

[Fail] [k8s.io] KubeletManagedEtcHosts [It] should test kubelet managed /etc/hosts file [Conformance] 
/home/lantaol/workspace/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/framework/exec_util.go:107

[Fail] [k8s.io] Networking [k8s.io] Granular Checks: Pods [It] should function for intra-pod communication: http [Conformance] 
/home/lantaol/workspace/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/framework/networking_utils.go:217

[Fail] [k8s.io] Container Runtime Conformance Test container runtime conformance blackbox test when running a container with a new image [It] should be able to pull from private registry with secret [Conformance] 
/home/lantaol/workspace/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e_node/runtime_conformance_test.go:385

Ran 122 of 217 Specs in 1491.024 seconds
FAIL! -- 116 Passed | 6 Failed | 0 Pending | 95 Skipped

The networking test and /etc/host test failed because they are using exec which we don't support now.
Image pulling test failed because we don't support pull image authentication.

@Random-Liu Random-Liu force-pushed the upgrade-containerd branch from 6bce918 to 8524a4e Compare June 19, 2017 18:44
mikebrow
mikebrow reviewed Jun 19, 2017
View reviewed changes
pkg/server/image_pull.go
// garbage collection.
// For now, we simply use it to store and retrieve information required for pulling an image.
// @stevvooe said we should `Put` before downloading content, However:
// 1) Containerd client put image metadata after downloading;
Copy link
Member

@mikebrow mikebrow Jun 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me should probably discuss with stevvooe maybe they client is wrong.. or maybe the advise has changes...

mikebrow
mikebrow approved these changes Jun 19, 2017
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Random-Liu
Copy link
Member Author

Random-Liu commented Jun 19, 2017

Apply LGTM based on #81 (review).

@Random-Liu Random-Liu merged commit 1a9d952 into containerd:master Jun 19, 2017
@Random-Liu Random-Liu deleted the upgrade-containerd branch June 19, 2017 19:59
@Random-Liu Random-Liu added this to the v0.1.0-alpha.1 milestone Jun 19, 2017
@Random-Liu Random-Liu mentioned this pull request Jun 20, 2017
Closed
lanchongyizu pushed a commit to lanchongyizu/cri-containerd that referenced this pull request Sep 3, 2017
@Random-Liu
Merge pull request containerd#81 from Random-Liu/upgrade-containerd
46f2198 
Upgrade containerd to 8ed1e24ae925b5c6d8195858ee89dddb0507d65f
kevpar added a commit to kevpar/cri that referenced this pull request Nov 24, 2020
@kevpar
Merge pull request containerd#81 from kevpar/argsescaped
9863254 
Fix Windows containers for Docker images relying on ArgsEscaped
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mikebrow mikebrow mikebrow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mikebrow mikebrow

Labels

cncf-cla: yes lgtm

Projects

None yet

Milestone

v0.1.0-alpha.1

Development

Successfully merging this pull request may close these issues.

3 participants

@Random-Liu @mikebrow @k8s-ci-robot