This repository was archived by the owner on Mar 9, 2022. It is now read-only.
Fix sandbox stop race condition. #743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikebrow
reviewed
Apr 18, 2018
pkg/server/sandbox_stop.go
Outdated
|
|
||
| // Delete the sandbox container from containerd. | ||
| _, err = task.Delete(ctx, containerd.WithProcessKill) | ||
| // Kill the sanbox container. |
Member
There was a problem hiding this comment.
Please update function comment on line 98 to:
// stopSandboxContainer kills the sandbox container.
// note: task.Delete is not called here because it will be called when the event monitor handles the TaskExit event
Signed-off-by: Lantao Liu <[email protected]>
Random-Liu
force-pushed
the
fix-sandbox-stop-race
branch
from
cbc29ff to
856534c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sandbox_stop.goshould only kill the sandbox container, and event monitor will handleTaskExitevent andDeletethe task.Errors caused by this race condition:
Signed-off-by: Lantao Liu [email protected]