This repository was archived by the owner on Mar 9, 2022. It is now read-only.
Change node e2e to use cni template. #742
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lantao Liu <[email protected]>
Member
Author
Member
Author
|
This should be fixed by kubernetes/kubernetes#62761. |
k8s-github-robot
pushed a commit
to kubernetes/kubernetes
that referenced
this pull request
Apr 18, 2018
…ummary Automatic merge from submit-queue (batch tested with PRs 62761, 62715). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Lower UsageNanoCores boundary in summary api test. We recently switched to use `p2p` instead of `bridge` in containerd containerd/cri#742. However, after that switch, the `UsageNanoCores` becomes lower, and constantly fails the test. An example failure: * https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/containerd_cri/740/pull-cri-containerd-node-e2e/690/ This is probably because: 1) The test container used in summary test does `ping`. https://github.com/kubernetes/kubernetes/blob/master/test/e2e_node/summary_test.go#L352 2) `p2p` is simpler than `bridge`, "Maybe cycles are saved from waiving Mac learning" - @jingax10. This PR lowers the boundary by 1 magnitude. Signed-off-by: Lantao Liu <[email protected]> **Release note**: ```release-note none ```
Member
|
/test pull-cri-containerd-node-e2e |
Member
Author
|
/test pull-cri-containerd-build |
Member
Author
|
Close this in favor of #740 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node e2e should also use cni template.
Signed-off-by: Lantao Liu [email protected]