This repository was archived by the owner on Mar 9, 2022. It is now read-only.
switches from not CA signed to self CA signed for streaming TLS #713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Let's hold this for now as some clients may still want the CA to be "known" so we would also need to configure self as a known CA for this scenario to work with all clients who do not specify insecure for the TLS certificate. |
Member
|
@mikebrow Please rebase this. |
Random-Liu
reviewed
Apr 2, 2018
pkg/server/streaming.go
Outdated
| if err != nil { | ||
| return fail(errors.Wrap(err, "failed to get hostname")) | ||
| } | ||
| host := fmt.Sprintf("%s:%s:%s", certOrganizationName, certCommonName, hostName) |
Member
There was a problem hiding this comment.
It seems that we don't to specify org and common name, the util function has done that for us.
Signed-off-by: Mike Brown <[email protected]>
Member
Author
|
@Random-Liu rebased.. |
Member
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue: #712
Signed-off-by: Mike Brown [email protected]