This repository was archived by the owner on Mar 9, 2022. It is now read-only.
Fix event monitor panic. #701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
Signed-off-by: Lantao Liu <[email protected]>
Random-Liu
force-pushed
the
fix-event-monitor-panic
branch
from
b1a1dc9 to
277edb2
Compare
yanxuean
reviewed
Mar 27, 2018
|
|
||
| type backOff struct { | ||
| queuePool map[string]*backOffQueue | ||
| queuePool map[string]*backOffQueue |
Member
Author
There was a problem hiding this comment.
That is gofmt result.
mikebrow
reviewed
Mar 27, 2018
| defer b.tickerMu.Unlock() | ||
| if b.ticker != nil { | ||
| b.ticker.Stop() | ||
| } |
Member
There was a problem hiding this comment.
else...logrus.WithError(err).Error("attempt to stop ticker before start has completed allocating the ticker")
note: should be impossible for this to happen now that you have a mutex... if the log is impossible we don't need the nil check..
Member
Author
There was a problem hiding this comment.
This is possible, user may CTRL+C before CRI service starts.
Member
There was a problem hiding this comment.
user interrupts ... interesting thx
| return nil, errors.New("event channel is nil") | ||
| } | ||
| closeCh := make(chan struct{}) | ||
| backOffCheckCh := em.backOff.start() |
Member
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the event monitor panic.
We should only stop ticker when it is not nil.
Since
startandstopcan be called at the same time, we need a lock to protect it.Signed-off-by: Lantao Liu [email protected]