This repository was archived by the owner on Mar 9, 2022. It is now read-only.
Add sandbox /etc/hosts. #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@Crazykev This PR is very similar with yours. Please take a look at this PR and address the comments in your PR correspondingly. |
Random-Liu
force-pushed
the
always-add-etc-hosts
branch
from
f216d44 to
6c4a7a8
Compare
42 tasks
Contributor
|
@Random-Liu THX, good to see |
Member
Author
|
@Crazykev You could fetch this commit to your PR, and send out. Will merge your PR after this one. |
Signed-off-by: Lantao Liu <[email protected]>
Signed-off-by: Lantao Liu <[email protected]>
Random-Liu
force-pushed
the
always-add-etc-hosts
branch
from
6c4a7a8 to
4eac00f
Compare
Member
Author
|
Apply LGTM based on #60 (review). |
lanchongyizu
pushed a commit
to lanchongyizu/cri-containerd
that referenced
this pull request
Sep 3, 2017
Add sandbox /etc/hosts.
dcantah
pushed a commit
to dcantah/cri
that referenced
this pull request
Apr 17, 2020
…e_v3.2 move to v3.2 for the pause image
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sandbox
/etc/hostsand mount it inside each container of the sandbox.Currently, in Kubelet,
/etc/hosts, we mount it when the sandbox is not using host network, and rely on the runtime to maintain it if the sandbox is using host network./etc/resolv.conf, we rely on the runtime to maintain it (dockershim overwrites it after creates sandbox container).From the perspective of a runtime, it's weird that we only maintain the file in some cases, and not in other cases.
So in this PR, I'll let
cri-containerdalways maintain/etc/hostsno matter the sandbox is using host network or not.In the future, we should make it consistent:
/cc @yujuhong