Finish image management. #41

Random-Liu · 2017-05-18T23:48:54Z

This PR finishes the containerd image management. There are still many TODOs to be addressed, I'll do them in some following PRs.

TODOs for this PR:

Add unit test as much as I can. Since containerd API is changing fast, I'll not add unit test for rootfs service related unit test now.
~~Add image list filters.~~

TODOs for future PRs:

1) Create rootfs and apply image config when creating sandbox/container. (Apply sandbox image config #48 and Apply container image config #52)

Some work for operation synchronization:

a) When pulling image, get digests of all resources associated to the image, wait for those pulling to be done by checking content status. This makes sure that concurrent pull which pulls the same resource won't return before the resource is fully pulled. (content store returns immediately for ongoing pulling). (Wait and check image pulling progress. #46)
b) We'll not need checkpoint for image management. Write a cleaner and easier to use image metadata which could lock more operations together because all data is in memory.
c) Add some synchronization between concurrent pulling/removing against the same image.

Add authentication support
Update containerd version to use the new snapshot service

This PR also depends on containerd/containerd#875.

Random-Liu · 2017-05-18T23:53:33Z

The PR already passed all CRI image validation test:

Running Suite: E2ECRI Suite
===========================
Random Seed: 1495147524 - Will randomize all specs
Will run 6 of 36 specs

SSSS
------------------------------
[k8s.io] Image Manager 
  image status get image fields should not be empty [Conformance]
  /usr/local/google/home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/image.go:74
[BeforeEach] [k8s.io] Image Manager
  /usr/local/google/home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:50
[BeforeEach] [k8s.io] Image Manager
  /usr/local/google/home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/image.go:48
[It] image status get image fields should not be empty [Conformance]
  /usr/local/google/home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/image.go:74
STEP: Pull image : busybox:1.26.2
STEP: Get image status
STEP: Get image status
STEP: Remove image : busybox:1.26.2
[AfterEach] [k8s.io] Image Manager
  /usr/local/google/home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:51
•SSSSS
------------------------------
[k8s.io] Image Manager 
  public image without tag should be pulled and removed [Conformance]
  /usr/local/google/home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/image.go:56
[BeforeEach] [k8s.io] Image Manager
  /usr/local/google/home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:50
[BeforeEach] [k8s.io] Image Manager
  /usr/local/google/home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/image.go:48
[It] public image without tag should be pulled and removed [Conformance]
  /usr/local/google/home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/image.go:56
STEP: Pull image : busybox:latest
STEP: Check image list to make sure pulling image success : busybox:latest
STEP: Get image list for imageName : busybox:latest
STEP: Remove image : busybox:latest
STEP: Remove image : busybox:latest
STEP: Check image list empty
STEP: Get image list for imageName : busybox:latest
[AfterEach] [k8s.io] Image Manager
  /usr/local/google/home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:51
•SSSSS
------------------------------
[k8s.io] Image Manager 
  public image with tag should be pulled and removed [Conformance]
  /usr/local/google/home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/image.go:52
[BeforeEach] [k8s.io] Image Manager
  /usr/local/google/home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:50
[BeforeEach] [k8s.io] Image Manager
  /usr/local/google/home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/image.go:48
[It] public image with tag should be pulled and removed [Conformance]
  /usr/local/google/home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/image.go:52
STEP: Pull image : busybox:1.26.2
STEP: Check image list to make sure pulling image success : busybox:1.26.2
STEP: Get image list for imageName : busybox:1.26.2
STEP: Remove image : busybox:1.26.2
STEP: Remove image : busybox:1.26.2
STEP: Check image list empty
STEP: Get image list for imageName : busybox:1.26.2
[AfterEach] [k8s.io] Image Manager
  /usr/local/google/home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:51
•SSSSS
------------------------------
[k8s.io] Image Manager 
  public image with digest should be pulled and removed [Conformance]
  /usr/local/google/home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/image.go:60
[BeforeEach] [k8s.io] Image Manager
  /usr/local/google/home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:50
[BeforeEach] [k8s.io] Image Manager
  /usr/local/google/home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/image.go:48
[It] public image with digest should be pulled and removed [Conformance]
  /usr/local/google/home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/image.go:60
STEP: Pull image : busybox@sha256:817a12c32a39bbe394944ba49de563e085f1d3c5266eb8e9723256bc4448680e
STEP: Check image list to make sure pulling image success : busybox@sha256:817a12c32a39bbe394944ba49de563e085f1d3c5266eb8e9723256bc4448680e
STEP: Get image list for imageName : busybox@sha256:817a12c32a39bbe394944ba49de563e085f1d3c5266eb8e9723256bc4448680e
STEP: Remove image : busybox@sha256:817a12c32a39bbe394944ba49de563e085f1d3c5266eb8e9723256bc4448680e
STEP: Remove image : busybox@sha256:817a12c32a39bbe394944ba49de563e085f1d3c5266eb8e9723256bc4448680e
STEP: Check image list empty
STEP: Get image list for imageName : busybox@sha256:817a12c32a39bbe394944ba49de563e085f1d3c5266eb8e9723256bc4448680e
[AfterEach] [k8s.io] Image Manager
  /usr/local/google/home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:51
•
------------------------------
[k8s.io] Image Manager 
  listImage should get exactly 3 image in the result list [Conformance]
  /usr/local/google/home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/image.go:109
[BeforeEach] [k8s.io] Image Manager
  /usr/local/google/home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:50
[BeforeEach] [k8s.io] Image Manager
  /usr/local/google/home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/image.go:48
[It] listImage should get exactly 3 image in the result list [Conformance]
  /usr/local/google/home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/image.go:109
STEP: Pull image : busybox:1-uclibc
STEP: Pull image : busybox:1-musl
STEP: Pull image : busybox:1-glibc
STEP: Remove image : busybox:1-uclibc
STEP: Remove image : busybox:1-musl
STEP: Remove image : busybox:1-glibc
[AfterEach] [k8s.io] Image Manager
  /usr/local/google/home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:51
•SSSSSSSSSS
------------------------------
[k8s.io] Image Manager 
  listImage should get exactly 3 repoTags in the result image [Conformance]
  /usr/local/google/home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/image.go:146
[BeforeEach] [k8s.io] Image Manager
  /usr/local/google/home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:50
[BeforeEach] [k8s.io] Image Manager
  /usr/local/google/home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/image.go:48
[It] listImage should get exactly 3 repoTags in the result image [Conformance]
  /usr/local/google/home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/image.go:146
STEP: Pull image : busybox:1.26.2-uclibc
STEP: Pull image : busybox:1-uclibc
STEP: Pull image : busybox:1
STEP: Remove image : busybox:1.26.2-uclibc
STEP: Remove image : busybox:1-uclibc
STEP: Remove image : busybox:1
[AfterEach] [k8s.io] Image Manager
  /usr/local/google/home/lantaol/workspace/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:51
•S
Ran 6 of 36 Specs in 8.229 seconds
SUCCESS! -- 6 Passed | 0 Failed | 0 Pending | 30 Skipped PAS
</details>S

mikebrow · 2017-05-19T23:23:43Z

Looking good so far!

Random-Liu · 2017-05-19T23:35:41Z

Slashed out the image filter work. The reasons are:

The api is not defined quite clear;
It's a little bit complex to implement image name match;
Kubelet is not using this feature.

Random-Liu · 2017-05-22T03:45:04Z

@mikebrow @yujuhong The PR is ready for review.

Random-Liu · 2017-05-23T00:12:31Z

/cc @stevvooe Could you help take a look when you have time? Just want to make sure we are using containerd image management api in a right way.

yujuhong · 2017-05-23T01:51:43Z

@mikebrow @yujuhong The PR is ready for review.

Will review this tomorrow.

yujuhong · 2017-05-24T00:13:27Z

pkg/metadata/image_metadata.go

-	// Size of the image in bytes. Must be > 0.
-	Size uint64 `json:"size,omitempty"`
+	// Size is the compressed size of the image.
+	Size int64 `json:"size,omitempty"`


Why changing this to int64?

Containerd returns int64, CRI uses uint64, so either is ok here. :)

yeah that's why I picked uint..

yujuhong · 2017-05-24T00:25:37Z

pkg/metadata/image_metadata.go

 // ImageMetadata is the unversioned image metadata.
 type ImageMetadata struct {
-	// Id of the image. Normally the Digest
+	// Id of the image. Normally the repo digest.


If RepoDigest is exactly the same as what docker may report, it'd be <registry>/<repository>@<digest>. I think the ID would just be the manifest digest.

Sorry, the id is the config digest. I forgot to update the comment.

yujuhong · 2017-05-24T00:37:43Z

pkg/server/helpers_test.go

+	} {
+		t.Logf("TestCase %q", ref)
+		normalized, err := normalizeImageRef(ref)
+		assert.NoError(t, err)


Shouldn't we verify that the normalized string is correct?

I'm not sure whether we want to make assumption about what the image reference is like after normalization. We just want to make sure containerd understand it.

E.g. if in the future the docker package normalize busybox as docker/busbox, it's fine for us as long as containerd understand it.

But you do own part of the normalization logic in normalizeImageRef()... The fact that containerd can accept it doesn't mean the reference was normarlized correctly.

yujuhong · 2017-05-24T00:38:46Z

pkg/server/helpers_test.go

+	assert.NoError(t, err)
+	normalizedD, err := normalizeImageRef(digested)
+	assert.NoError(t, err)
+	assert.Equal(t, normalizedTD.String(), normalizedD.String())


Is it enough that they are equal? We can also test that the the normalized string uses the digest.

Same with above.

Same as above. You don't just call a docker library function to normalize the string, you did a function yourself to perform the task.

yujuhong · 2017-05-24T00:41:31Z

pkg/metadata/image_metadata.go

+	// Id of the image. Normally the repo digest.
 	ID string `json:"id,omitempty"`
+	// ChainID is the chainID of the image.
+	ChainID string `json:"chain_id,omitempty"`


Just out of curiosity, what about the digest of the image config?

It is the image id. Sorry for the wrong comment.

yujuhong · 2017-05-24T01:42:06Z

pkg/server/helpers.go

+
+// getUserFromImageUser gets uid or user name of the image user.
+// If user is numeric, it will be treated as uid; or else, it is treated as user name.
+func getUserFromImageUser(user string) (*int64, string) {


nit: getUserFromImage seems clear enough to me.

Copied the function from dockershim. Will do.

yujuhong · 2017-05-24T01:42:40Z

pkg/server/helpers.go

+// getUserFromImageUser gets uid or user name of the image user.
+// If user is numeric, it will be treated as uid; or else, it is treated as user name.
+func getUserFromImageUser(user string) (*int64, string) {
+	// return both nil if user is not specified in the image.


but you return nil and an empty string below.

yujuhong · 2017-05-24T01:49:58Z

pkg/server/image_remove.go

-	// TODO(mikebrow): remove the image via containerd
-	err := c.imageMetadataStore.Delete(r.GetImage().GetImage())
-	return &runtime.RemoveImageResponse{}, err
+// TODO(random-liu): Update CRI to pass image reference instead of ImageSpec.


Can link my issue if you want: kubernetes/kubernetes#46255

yujuhong · 2017-05-24T01:53:48Z

pkg/server/image_status.go

+		return nil, fmt.Errorf("can not resolve %q locally: %v", r.GetImage().GetImage(), err)
+	}
+	if imageID == "" {
+		// return empty without error when image not found.


Why not returning an error?

This is defined in CRI. https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/apis/cri/v1alpha1/api.proto#L85-L88

And we're actually relying on this behavior.

Why not use codes.NotFound?

@stevvooe We should. I'll file an issue in Kubernetes repo about this. Thanks

Done. kubernetes/kubernetes#46469

yujuhong · 2017-05-24T01:54:49Z

pkg/server/image_status_test.go

+		Image: &runtime.ImageSpec{Image: testID},
+	})
+	assert.NoError(t, err)
+	assert.NotNil(t, resp)


require :-)

stevvooe · 2017-05-25T16:41:11Z

pkg/server/helpers.go

+
+// normalizeImageRef normalizes the image reference following the docker convention. This is added
+// mainly for backward compatibility.
+// The reference returned can only be either tagged or digested. For reference contains both tag


The reference returned can only be either tagged or digested

This statement is untrue: we support digested references with tags, as well.

@stevvooe The problem is that I don't know where to fit it in our current RepoDigests and RepoTags model...

/cc @yujuhong

@Random-Liu I see. And hence the problem with that model. ;)

I suppose you can split them into a tagged and digested reference (as I think is being done here).

Random-Liu · 2017-05-25T16:48:40Z

@stevvooe Some comments in the PR are out-of-date. I'll push a newer version first to help you review. And then address other comments.

mikebrow · 2017-05-26T05:50:23Z

pkg/server/image_pull.go

+	_, desc, fetcher, err := resolver.Resolve(ctx, ref)
 	if err != nil {
-		return desc, size, fmt.Errorf("failed to resolve ref %q: err: %v", ref, err)
+		return "", "", fmt.Errorf("failed to resolve ref %q: %v", ref, err)


why change all these is there some rule that all errors in kube must return invalid return nil values for all params?

Yeah, we should return empty value on error usually, unless clearly defined that user could still use the return value on error.

mikebrow · 2017-05-26T05:54:54Z

pkg/server/image_pull.go

 		desc)
 	if err != nil {
-		return desc, size, fmt.Errorf("failed to fetch %q: desc: %v err: %v", resolvedImageName, desc, err)
+		return "", "", fmt.Errorf("failed to fetch image %q desc %+v: %v", ref, desc, err)


should we be consistent and add field names to all such structures in error outputs? or was there a special purpose on this one?

Just make the error output consistent. Usually, it's message: error.

I mean using %+v vs %v

Usually use %+v for structure, which will include field name. %v doesn't include field name.

yes I understand the usage of + for field names my point was "should we be consistent and add said field names to all such structures in error outputs?" With obvious exceptions for standard structures like "error"

maybe an issue for error message consistency and add this to it?

yes I understand the usage of + for field names my point was "should we be consistent and add said field names to all such structures in error outputs?" With obvious exceptions for standard structures like "error"

Yeah, we should. Will file an issue.

mikebrow · 2017-05-26T05:56:14Z

pkg/server/image_pull.go

+		return "", "", fmt.Errorf("unpack failed for manifest layers %v: %v", manifest.Layers, err)
 	}
-	size, err = image.Size(ctx, c.contentProvider)
+	// TODO(random-liu): Considering how to deal with the disk usage of content.


no err check?

Which error are you talking about?

the pink line :-) nvm

mikebrow · 2017-05-26T05:59:26Z

pkg/server/image_pull.go

 	if err != nil {
-		return desc, size,
-			fmt.Errorf("size failed for image:%q %v", image.Target.Digest, err)
+		return "", "", fmt.Errorf("failed to get config descriptor for image %q: %v", ref, err)


changed all the others to if var,err = exp; err !=nil { style but not this one.. Is there some rule for style here that we are adhering to?

Because we need configDesc later, so we could not assign it in if clause.

If we don't care about the return value later, we could put them in one line.

that's what var's are for :-) ok just checking why / if I'm missing something on these edits.

mikebrow · 2017-05-26T06:00:15Z

pkg/server/image_pull.go

+
+// insertToStringSlice is a helper function to insert a string into the string slice
+// if the string is not in the slice yet.
+func insertToStringSlice(ss []string, s string) []string {


do we have a place for string helpers?

Currently, this is only used in image_pull. In the future, we can add a separate package for the string helpers, if we need more.

yeah but who would know we have one here? just sayin :-)

mikebrow · 2017-05-26T06:02:27Z

pkg/server/image_remove.go

+		}
+	}()
+	imageID, err := c.localResolve(ctx, r.GetImage().GetImage())
+	glog.V(0).Infof("Image ref to remove %q", imageID)


logging between error check and assign may cause confusion if error

This was for testing. I'll remove it.. Sorry

yujuhong · 2017-05-26T20:33:24Z

pkg/server/image_pull.go

-	// Resolve the image name; place that in the image store; then dispatch
-	// a handler for a sequence of handlers which: 1) fetch the object using a
-	// FetchHandler; and 3) recurse through any sub-layers via a ChildrenHandler
+// pullImage pulls image and returns image id (config digest) and digest.


IIUC
s/and digest/and manifest digest

yujuhong · 2017-05-26T20:36:21Z

pkg/server/image_pull.go

-	// FetchHandler; and 3) recurse through any sub-layers via a ChildrenHandler
+// pullImage pulls image and returns image id (config digest) and digest.
+// TODO(random-liu): [P0] Wait for all downloadings to be done before return.
+func (c *criContainerdService) pullImage(ctx context.Context, ref string) (


Clarify what ref is in this context. I believe it should be normalized at the least.

ACK. It should be normalized image reference.

yujuhong · 2017-05-26T20:41:25Z

pkg/server/image_pull.go

 	}
+	// Currently, the resolved image name is the same with ref in docker resolver,
+	// but they may be different in the future.
+	// TODO(random-liu): Always resolve image reference and use resolved image name in


but you discarded the name returned by resolver.Resolve() and continue using ref in the rest of the code, why?

Filed containerd/containerd#924 for this

yujuhong · 2017-05-26T20:44:40Z

pkg/server/image_pull.go

 	}

-	image, err := c.imageStoreService.Get(ctx, resolvedImageName)
+	// Read the image manifest from content store.


nit: the store is sometimes referred as "content store" and sometimes just "image store". Would help to be consistent for all the comments.

The underlying logic does get image manifest from content store. I should probably move the comment down by one line.

yujuhong · 2017-05-26T21:24:41Z

pkg/server/image_pull.go

-	err = c.imageStoreService.Put(ctx, resolvedImageName, desc)
-	if err != nil {
-		return desc, size, fmt.Errorf("failed to put %q: desc: %v err: %v", resolvedImageName, desc, err)
+	// Put the image information into containerd image store.


Add comments to describe what this does, e.g.,

// In the future, containerd will rely on the information in the image store to perform image garbage collection. // For now, we simply use it to store and retrieve information required for pulling an image.

yujuhong · 2017-05-26T21:49:08Z

pkg/server/image_pull.go

+
+	// Unpack the image layers into snapshots.
+	if _, err = c.rootfsUnpacker.Unpack(ctx, manifest.Layers); err != nil {
+		return "", "", fmt.Errorf("unpack failed for manifest layers %v: %v", manifest.Layers, err)


nit: %+v for printing manifest.Layers

yujuhong · 2017-05-26T21:55:06Z

pkg/server/image_pull.go

+		return "", "", fmt.Errorf("failed to get image %q from containerd image store: %v", ref, err)
 	}
-	p, err := content.ReadBlob(ctx, c.contentProvider, image.Target.Digest)
+	digest := image.Target.Digest


Can we rename this to manifestDigest to help keeping my sanity? ;)

yujuhong · 2017-05-26T22:01:17Z

pkg/server/image_pull.go

-	named, err := reference.ParseNormalizedNamed(ref)
+	// TODO(random-liu): [P1] Schema 1 image is not supported in containerd now, we need to support
+	// it for backward compatiblity.
+	cfgDigest, digest, err := c.pullImage(ctx, image)


Let's have consistent naming for these two. Maybe cfgDigest and manifestDigest?
digest itself means very little...

yujuhong · 2017-05-26T22:06:29Z

pkg/server/image_pull.go

+	glog.V(4).Infof("Pulled image %q with image id %q, digest %q", image, imageID, digest)
+
+	var repoTag string
+	if _, ok := namedRef.(reference.NamedTagged); ok {


Why not make this a helper function too? or you can make getRepoDigestAndTags and return both.

yujuhong · 2017-05-26T22:10:24Z

pkg/server/image_pull.go

+		repoTag = namedRef.String()
+	}
+	repoDigest := getRepoDigest(namedRef, digest)
+	_, err = c.imageMetadataStore.Get(imageID)


Another option is to store namedRef in the metadata store, and only convert it to repoDigest/repoTags whenever needed. This way, you are not committed to persist RepoDigest and RepoTags for the foreseeable future.

Offline discussed, we won't persist the metadata in the future. And we do use repodigests and repotags in cri-containerd when delete image now.

Random-Liu · 2017-05-26T23:24:46Z

@yujuhong Addressed comments.

mikebrow

LGTM

yujuhong · 2017-05-26T23:43:18Z

LGTM. I look forward to using the new contanierd client ;)

Random-Liu · 2017-05-26T23:51:06Z

Apply LGTM based on #41 (comment), #41 (review)

Signed-off-by: Random-Liu <[email protected]>

Finish image management.

…vendor revendor containerd to include shim reconnect fix

Random-Liu assigned yujuhong and mikebrow May 18, 2017

k8s-ci-robot added the cncf-cla: yes label May 18, 2017

Random-Liu force-pushed the finish-image-management branch 2 times, most recently from c157d02 to c2a21af Compare May 19, 2017 00:29

Random-Liu force-pushed the finish-image-management branch from c2a21af to 258e61d Compare May 22, 2017 03:44

Random-Liu force-pushed the finish-image-management branch from 258e61d to c5d363f Compare May 22, 2017 21:03

Random-Liu mentioned this pull request May 24, 2017

Wait and check image pulling progress. #46

Merged

yujuhong reviewed May 24, 2017

View reviewed changes

This was referenced May 24, 2017

Apply sandbox image config #48

Merged

Apply container image config #52

Merged

stevvooe reviewed May 25, 2017

View reviewed changes

Random-Liu force-pushed the finish-image-management branch 5 times, most recently from 7adca5e to 441e356 Compare May 25, 2017 21:00

Random-Liu mentioned this pull request May 26, 2017

Add other small functions #53

Merged

mikebrow reviewed May 26, 2017

View reviewed changes

Random-Liu force-pushed the finish-image-management branch from 441e356 to 7364a46 Compare May 26, 2017 06:27

yujuhong reviewed May 26, 2017

View reviewed changes

mikebrow approved these changes May 26, 2017

View reviewed changes

Random-Liu force-pushed the finish-image-management branch from a01c86b to 5b23b99 Compare May 26, 2017 23:37

Random-Liu added the lgtm label May 26, 2017

Random-Liu added 2 commits May 26, 2017 23:52

Finish image management.

b112418

Signed-off-by: Random-Liu <[email protected]>

Add unit test.

8c1f267

Signed-off-by: Random-Liu <[email protected]>

Random-Liu force-pushed the finish-image-management branch from 5b23b99 to 8c1f267 Compare May 26, 2017 23:52

Random-Liu merged commit bdc443a into containerd:master May 27, 2017

Random-Liu deleted the finish-image-management branch May 27, 2017 00:04

lanchongyizu pushed a commit to lanchongyizu/cri-containerd that referenced this pull request Sep 3, 2017

Merge pull request containerd#41 from Random-Liu/finish-image-management

ee7103b

Finish image management.

adelina-t pushed a commit to adelina-t/cri that referenced this pull request Sep 24, 2019

Merge pull request containerd#41 from katiewasnothere/shim_connect_re…

6e8542d

…vendor revendor containerd to include shim reconnect fix

Finish image management. #41

Finish image management. #41

Uh oh!

Conversation

Random-Liu commented May 18, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Random-Liu commented May 18, 2017

Uh oh!

mikebrow commented May 19, 2017

Uh oh!

Random-Liu commented May 19, 2017

Uh oh!

Random-Liu commented May 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Random-Liu commented May 23, 2017

Uh oh!

yujuhong commented May 23, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Random-Liu May 25, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Random-Liu commented May 18, 2017 •

edited

Loading

Random-Liu commented May 22, 2017 •

edited

Loading

Random-Liu May 25, 2017 •

edited

Loading

Random-Liu May 25, 2017 •

edited

Loading

mikebrow May 26, 2017 •

edited

Loading

Random-Liu May 26, 2017 •

edited

Loading

mikebrow May 26, 2017 •

edited

Loading