Skip to content
This repository was archived by the owner on Mar 9, 2022. It is now read-only.

Add the missing container log path in container status. #372

Merged
Random-Liu merged 1 commit into from
Oct 30, 2017
Merged

Add the missing container log path in container status. #372

Random-Liu merged 1 commit into from
Oct 30, 2017

Conversation

@Random-Liu
Copy link
Member

@Random-Liu Random-Liu commented Oct 30, 2017 •
edited
Loading

The field was introduced kubernetes/kubernetes#45580, we should provide it because crictl is using it.
Signed-off-by: Lantao Liu [email protected]

mikebrow
mikebrow approved these changes Oct 30, 2017
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@Random-Liu Random-Liu merged commit dcb22be into containerd:master Oct 30, 2017
@Random-Liu Random-Liu deleted the add-container-log-path branch October 30, 2017 15:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mikebrow mikebrow mikebrow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@abhi abhi

@mikebrow mikebrow

Labels

cncf-cla: yes lgtm size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Random-Liu @mikebrow @abhi @k8s-ci-robot