This repository was archived by the owner on Mar 9, 2022. It is now read-only.
Add stack dump. #366
Merged
Add stack dump. #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Random-Liu
force-pushed
the
add-dump-stack
branch
from
de5a789 to
399a493
Compare
mikebrow
reviewed
Oct 27, 2017
| }() | ||
| } | ||
|
|
||
| func dumpStacks() { |
Member
There was a problem hiding this comment.
from: https://golang.org/src/runtime/debug/stack.go, just a little cleaner with a modification to dump all (true)
func stack() []byte {
buf := make([]byte, 1024)
for {
n := runtime.Stack(buf, true)
if n < len(buf) {
return buf[:n]
}
buf = make([]byte, 2*len(buf))
}
}
mikebrow
approved these changes
Oct 27, 2017
Member
mikebrow
left a comment
mikebrow
left a comment
There was a problem hiding this comment.
/LGTM either way with or without the stack() api..
Random-Liu
force-pushed
the
add-dump-stack
branch
from
399a493 to
b4b679e
Compare
Signed-off-by: Lantao Liu <[email protected]>
Random-Liu
force-pushed
the
add-dump-stack
branch
from
b4b679e to
439ee0a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the same code with containerd/containerd#292.
Signed-off-by: Lantao Liu [email protected]