This repository was archived by the owner on Mar 9, 2022. It is now read-only.
Use EnsureRemoveAll #206
Merged
Use EnsureRemoveAll #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
mikebrow
suggested changes
Sep 4, 2017
Member
mikebrow
left a comment
mikebrow
left a comment
There was a problem hiding this comment.
Nice wrapper. Split the vendor commit and good to go.
Member
Author
|
Will do. |
Signed-off-by: Lantao Liu <[email protected]>
Signed-off-by: Lantao Liu <[email protected]>
Random-Liu
force-pushed
the
ensure-remove-all
branch
from
08d7e08 to
adfabda
Compare
Member
Author
|
@mikebrow Done. |
mikebrow
approved these changes
Sep 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
EnsureRemoveAllto recursively umount and remove container and sandbox directory.This function will also be useful during checkpoint recovery.
Signed-off-by: Lantao Liu [email protected]