This repository was archived by the owner on Mar 9, 2022. It is now read-only.
Add instrumented service. #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Should we convert those logs to something like debugf in logrus. I see that glog has severity level may be print those logs only if the logging level is set appropriately ? Instead of an instrumented code. |
Member
Author
|
@abhinandanpb I did this not for the log level. :) Just extract the log logic into an outside wrapper, so that we don't need to see this everywhere. :) More of a cleanup. |
abhi
reviewed
Aug 23, 2017
pkg/server/instrumented_service.go
Outdated
| glog.V(2).Infof("RunPodSandbox with config %+v", r.GetConfig()) | ||
| defer func() { | ||
| if err != nil { | ||
| glog.Errorf("RunPodSandbox for %+v returns error %v", r.GetConfig().GetMetadata(), err) |
Member
There was a problem hiding this comment.
glog.Errorf("RunPodSandbox for %+v failed, err: %v", r.GetConfig().GetMetadata(), err)
would be better ?
Signed-off-by: Lantao Liu <[email protected]>
Random-Liu
force-pushed
the
add-instrumented-service
branch
from
f935cd4 to
195b525
Compare
Member
|
LGTM |
Member
Author
lanchongyizu
pushed a commit
to lanchongyizu/cri-containerd
that referenced
this pull request
Sep 3, 2017
…rvice Add instrumented service.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all grpc handler logs into a instrumented service, so that we don't need to care about it in the real service.
Signed-off-by: Lantao Liu [email protected]