Add container Exec support. #115
Conversation
Signed-off-by: Lantao Liu <[email protected]>
mikebrow
left a comment
mikebrow
left a comment
There was a problem hiding this comment.
Just a couple questions and one nit.
| @@ -100,16 +149,11 @@ func (c *criContainerdService) ExecSync(ctx context.Context, r *runtime.ExecSync | |||
| if err != nil { | |||
| return nil, fmt.Errorf("failed to wait for exec in container %q to finish: %v", id, err) | |||
There was a problem hiding this comment.
always throw out the exit code if there is an error? unknownExitCode?
There was a problem hiding this comment.
Maybe we should let waitContainerExec also return pointer, so that we don't need the unknownExitStatus for now.
We don't use the exit code when there is an error now.
There was a problem hiding this comment.
right.. just trying to figure out if that's on purpose. Seems at least possible to have an exit code and an error. Not a fan of throwing it out unless we need to.
| // imageStoreService is the containerd service to store and track | ||
| // image metadata. | ||
| imageStoreService images.Store | ||
| // eventsService is the containerd task service client |
There was a problem hiding this comment.
just curious why this one is better up here?
There was a problem hiding this comment.
Just group containerd services together. No particular reason. :)
pkg/server/service.go
Outdated
| c.startEventMonitor() | ||
| go func() { | ||
| if err := c.streamServer.Start(true); err != nil { | ||
| glog.Errorf("Failed to start streaing server: %v", err) |
Signed-off-by: Lantao Liu <[email protected]>
Random-Liu
force-pushed
the
support-container-streaming
branch
from
d30058f to
4421cab
Compare
|
@mikebrow Addressed comments. |
Signed-off-by: Lantao Liu <[email protected]>
Signed-off-by: Lantao Liu <[email protected]>
Random-Liu
force-pushed
the
support-container-streaming
branch
from
4421cab to
75731c8
Compare
…treaming Add container Exec support.
3 participants
This PR:
Execsupport.ExecCRI validation test./cc @kubernetes-incubator/maintainers-cri-containerd