Results from make command are not reproducible

[gnufied]

I think because make uses csi.proto.tmp file and lib files get regenerated from tmp file, the result of make command is not reproducible. Also tmp file is gitignored and hence one branch may silently reuse result from another branch making authoring process harder.

cc @jdef @saad-ali

[gnufied]

Also - I cloned the repo on a new Ubuntu 16.04 VM with go1.9.5 and ran make. After make, ran git status and got:

─[vagrant][ubuntu-16-go-195][±][master U:1 ✗][~/goal/src/github.com/container-storage-interface/spec]
└─▪ git status
On branch master
Your branch is up-to-date with 'origin/master'.
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

        modified:   lib/go/csi/v0/csi.pb.go

no changes added to commit (use "git add" and/or "git commit -a")

Quickly running `git diff" shows:

diff --git a/lib/go/csi/v0/csi.pb.go b/lib/go/csi/v0/csi.pb.go
index 1b02d7b..9320500 100644
--- a/lib/go/csi/v0/csi.pb.go
+++ b/lib/go/csi/v0/csi.pb.go
@@ -1,54 +1,6 @@
 // Code generated by protoc-gen-go. DO NOT EDIT.
 // source: csi.proto
 
-/*
-Package csi is a generated protocol buffer package.
-
-It is generated from these files:
-       csi.proto
-
-It has these top-level messages:
-       GetPluginInfoRequest
-       GetPluginInfoResponse
-       GetPluginCapabilitiesRequest
-       GetPluginCapabilitiesResponse
-       PluginCapability
-       ProbeRequest
-       ProbeResponse
-       CreateVolumeRequest
-       CreateVolumeResponse
-       VolumeCapability
-       CapacityRange
-       Volume
-       DeleteVolumeRequest
-       DeleteVolumeResponse
-       ControllerPublishVolumeRequest
-       ControllerPublishVolumeResponse
-       ControllerUnpublishVolumeRequest
-       ControllerUnpublishVolumeResponse
-       ValidateVolumeCapabilitiesRequest
-       ValidateVolumeCapabilitiesResponse
-       ListVolumesRequest
-       ListVolumesResponse
-       GetCapacityRequest
-       GetCapacityResponse
-       ControllerGetCapabilitiesRequest
-       ControllerGetCapabilitiesResponse
-       ControllerServiceCapability
-       NodeStageVolumeRequest
-       NodeStageVolumeResponse
-       NodeUnstageVolumeRequest
-       NodeUnstageVolumeResponse
-       NodePublishVolumeRequest
-       NodePublishVolumeResponse
-       NodeUnpublishVolumeRequest
-       NodeUnpublishVolumeResponse
-       NodeGetIdRequest
-       NodeGetIdResponse
-       NodeGetCapabilitiesRequest
-       NodeGetCapabilitiesResponse
-       NodeServiceCapability
-*/
 package csi
 
 import proto "github.com/golang/protobuf/proto"
@@ -99,7 +51,7 @@ func (x PluginCapability_Service_Type) String() string {
        return proto.EnumName(PluginCapability_Service_Type_name, int32(x))
 }
 func (PluginCapability_Service_Type) EnumDescriptor() ([]byte, []int) {
-       return fileDescriptor0, []int{4, 0, 0}
+       return fileDescriptor_csi_b09f5c5da9b60591, []int{4, 0, 0}
 }
 
 type VolumeCapability_AccessMode_Mode int32
@@ -143,7 +95,7 @@ func (x VolumeCapability_AccessMode_Mode) String() string {
        return proto.EnumName(VolumeCapability_AccessMode_Mode_name, int32(x))
 }
 func (VolumeCapability_AccessMode_Mode) EnumDescriptor() ([]byte, []int) {
-       return fileDescriptor0, []int{9, 2, 0}
+       return fileDescriptor_csi_b09f5c5da9b60591, []int{9, 2, 0}
 }
 

[jdef]

Maybe you're using a different version of the golang/protobuf library?

…

On Mon, Apr 30, 2018 at 10:46 PM, Hemant Kumar ***@***.***> wrote: Also - I cloned the repo on a new Ubuntu 16.04 VM with go1.9.5 and ran make. After make, ran git status and got: ─[vagrant][ubuntu-16-go-195][±][master U:1 ✗][~/goal/src/github.com/container-storage-interface/spec] └─▪ git status On branch master Your branch is up-to-date with 'origin/master'. Changes not staged for commit: (use "git add <file>..." to update what will be committed) (use "git checkout -- <file>..." to discard changes in working directory) modified: lib/go/csi/v0/csi.pb.go no changes added to commit (use "git add" and/or "git commit -a") Quickly running `git diff" shows: diff --git a/lib/go/csi/v0/csi.pb.go b/lib/go/csi/v0/csi.pb.go index 1b02d7b..9320500 100644 --- a/lib/go/csi/v0/csi.pb.go +++ b/lib/go/csi/v0/csi.pb.go @@ -1,54 +1,6 @@ // Code generated by protoc-gen-go. DO NOT EDIT. // source: csi.proto -/* -Package csi is a generated protocol buffer package. - -It is generated from these files: - csi.proto - -It has these top-level messages: - GetPluginInfoRequest - GetPluginInfoResponse - GetPluginCapabilitiesRequest - GetPluginCapabilitiesResponse - PluginCapability - ProbeRequest - ProbeResponse - CreateVolumeRequest - CreateVolumeResponse - VolumeCapability - CapacityRange - Volume - DeleteVolumeRequest - DeleteVolumeResponse - ControllerPublishVolumeRequest - ControllerPublishVolumeResponse - ControllerUnpublishVolumeRequest - ControllerUnpublishVolumeResponse - ValidateVolumeCapabilitiesRequest - ValidateVolumeCapabilitiesResponse - ListVolumesRequest - ListVolumesResponse - GetCapacityRequest - GetCapacityResponse - ControllerGetCapabilitiesRequest - ControllerGetCapabilitiesResponse - ControllerServiceCapability - NodeStageVolumeRequest - NodeStageVolumeResponse - NodeUnstageVolumeRequest - NodeUnstageVolumeResponse - NodePublishVolumeRequest - NodePublishVolumeResponse - NodeUnpublishVolumeRequest - NodeUnpublishVolumeResponse - NodeGetIdRequest - NodeGetIdResponse - NodeGetCapabilitiesRequest - NodeGetCapabilitiesResponse - NodeServiceCapability -*/ package csi import proto "github.com/golang/protobuf/proto" @@ -99,7 +51,7 @@ func (x PluginCapability_Service_Type) String() string { return proto.EnumName(PluginCapability_Service_Type_name, int32(x)) } func (PluginCapability_Service_Type) EnumDescriptor() ([]byte, []int) { - return fileDescriptor0, []int{4, 0, 0} + return fileDescriptor_csi_b09f5c5da9b60591, []int{4, 0, 0} } type VolumeCapability_AccessMode_Mode int32 @@ -143,7 +95,7 @@ func (x VolumeCapability_AccessMode_Mode) String() string { return proto.EnumName(VolumeCapability_AccessMode_Mode_name, int32(x)) } func (VolumeCapability_AccessMode_Mode) EnumDescriptor() ([]byte, []int) { - return fileDescriptor0, []int{9, 2, 0} + return fileDescriptor_csi_b09f5c5da9b60591, []int{9, 2, 0} } — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#226 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACPVLPot-fFNHOANvmQpNQp950tA4i1Mks5tt8yNgaJpZM4TtSod> .

[jdef]

Ah, looks like the golang/protobuf team finally merged their dev branch to master, which changes the format of the generated output. We'll need to make some changes here to rectify prior to merging any other PRs

…

On Tue, May 1, 2018 at 6:26 AM, James DeFelice ***@***.***> wrote: Maybe you're using a different version of the golang/protobuf library? On Mon, Apr 30, 2018 at 10:46 PM, Hemant Kumar ***@***.***> wrote: > Also - I cloned the repo on a new Ubuntu 16.04 VM with go1.9.5 and ran > make. After make, ran git status and got: > > ─[vagrant][ubuntu-16-go-195][±][master U:1 ✗][~/goal/src/github.com/container-storage-interface/spec] > └─▪ git status > On branch master > Your branch is up-to-date with 'origin/master'. > Changes not staged for commit: > (use "git add <file>..." to update what will be committed) > (use "git checkout -- <file>..." to discard changes in working directory) > > modified: lib/go/csi/v0/csi.pb.go > > no changes added to commit (use "git add" and/or "git commit -a") > > Quickly running `git diff" shows: > > diff --git a/lib/go/csi/v0/csi.pb.go b/lib/go/csi/v0/csi.pb.go > index 1b02d7b..9320500 100644 > --- a/lib/go/csi/v0/csi.pb.go > +++ b/lib/go/csi/v0/csi.pb.go > @@ -1,54 +1,6 @@ > // Code generated by protoc-gen-go. DO NOT EDIT. > // source: csi.proto > > -/* > -Package csi is a generated protocol buffer package. > - > -It is generated from these files: > - csi.proto > - > -It has these top-level messages: > - GetPluginInfoRequest > - GetPluginInfoResponse > - GetPluginCapabilitiesRequest > - GetPluginCapabilitiesResponse > - PluginCapability > - ProbeRequest > - ProbeResponse > - CreateVolumeRequest > - CreateVolumeResponse > - VolumeCapability > - CapacityRange > - Volume > - DeleteVolumeRequest > - DeleteVolumeResponse > - ControllerPublishVolumeRequest > - ControllerPublishVolumeResponse > - ControllerUnpublishVolumeRequest > - ControllerUnpublishVolumeResponse > - ValidateVolumeCapabilitiesRequest > - ValidateVolumeCapabilitiesResponse > - ListVolumesRequest > - ListVolumesResponse > - GetCapacityRequest > - GetCapacityResponse > - ControllerGetCapabilitiesRequest > - ControllerGetCapabilitiesResponse > - ControllerServiceCapability > - NodeStageVolumeRequest > - NodeStageVolumeResponse > - NodeUnstageVolumeRequest > - NodeUnstageVolumeResponse > - NodePublishVolumeRequest > - NodePublishVolumeResponse > - NodeUnpublishVolumeRequest > - NodeUnpublishVolumeResponse > - NodeGetIdRequest > - NodeGetIdResponse > - NodeGetCapabilitiesRequest > - NodeGetCapabilitiesResponse > - NodeServiceCapability > -*/ > package csi > > import proto "github.com/golang/protobuf/proto" > @@ -99,7 +51,7 @@ func (x PluginCapability_Service_Type) String() string { > return proto.EnumName(PluginCapability_Service_Type_name, int32(x)) > } > func (PluginCapability_Service_Type) EnumDescriptor() ([]byte, []int) { > - return fileDescriptor0, []int{4, 0, 0} > + return fileDescriptor_csi_b09f5c5da9b60591, []int{4, 0, 0} > } > > type VolumeCapability_AccessMode_Mode int32 > @@ -143,7 +95,7 @@ func (x VolumeCapability_AccessMode_Mode) String() string { > return proto.EnumName(VolumeCapability_AccessMode_Mode_name, int32(x)) > } > func (VolumeCapability_AccessMode_Mode) EnumDescriptor() ([]byte, []int) { > - return fileDescriptor0, []int{9, 2, 0} > + return fileDescriptor_csi_b09f5c5da9b60591, []int{9, 2, 0} > } > > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#226 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ACPVLPot-fFNHOANvmQpNQp950tA4i1Mks5tt8yNgaJpZM4TtSod> > . >