Fix deadlock on request timeout#389
Merged
Merged
Conversation
MartinJrP
force-pushed
the
fix-timeout-deadlock
branch
2 times, most recently
from
bc31fa7 to
cfcb401
Compare
MartinJrP
changed the title
Collaborator
|
Thank you for the submission @MartinJrP! It doesn't look like the |
MartinJrP
force-pushed
the
fix-timeout-deadlock
branch
from
cfcb401 to
40b86c6
Compare
Signed-off-by: Martin Jr Powlette <hi@martinjrpowlette.com>
MartinJrP
force-pushed
the
fix-timeout-deadlock
branch
from
40b86c6 to
5c5355e
Compare
Contributor
Author
|
Sorry about that @rebello95 and thanks for your patience! Should be good to go now -- found another deadlock |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
When creating a
ProtocolClientwith a timeoutTimeoutTimerdeadlocks when the deadline is reached. IfonTimeoutcallsTimeoutTimer.cancelthe thread deadlocks becausecancelblocks execution of the work item.ProtocolClientdoesn't trigger this directly -- rather whenTimeoutTimergets deallocated it calls cancel.Fix
DispatchWorkItemis thread safe so there's no need to call it on the class' private queue.