Weakify urlSessionStream in request callbacks to avoid retain cycles#359
Merged
Merged
Conversation
patryk-sredzinski
changed the title
rebello95
approved these changes
Jul 4, 2025
rebello95
left a comment
rebello95
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for the fix! Please address the DCO CI failure, and we can merge after 😄
patryk-sredzinski
force-pushed
the
stream-retain-cycle-fix
branch
from
8b321a0 to
dcc9702
Compare
Contributor
Author
|
Corrected the Commit. Is it fine now? |
Collaborator
|
Yes, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposal that solves the issue: #358