Remove content-length when using web clients#20
Merged
Conversation
srikrsna-buf
reviewed
May 7, 2025
srikrsna-buf
left a comment
srikrsna-buf
left a comment
Member
There was a problem hiding this comment.
Looks good! Can you also signoff on the commits?
nicksnyder
changed the title
Signed-off-by: Ben Ridley <ben@brids.dev>
Contributor
Author
|
Oops sorry for the noise @srikrsna-buf, I think it must have been auto formatting. Anyway, I've signed off and removed the unrelated edits. Thanks! |
srikrsna-buf
approved these changes
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures we always remove the content-length & content-encoding headers when using fetch-based HTTP clients.
It was discovered that when performing length checks in the protocol code, the length supplied by these clients was often incorrect because the browser has already performed decompression on the response. By removing these headers when using the web client, we forgo length checks and instead rely on the protocol parsing to validate any malformed responses.
Fixes #13.