Add connection management for H/2#10
Merged
Merged
Conversation
Signed-off-by: Sri Krishna <skrishna@buf.build>
Signed-off-by: Sri Krishna <skrishna@buf.build>
smaye81
approved these changes
Feb 12, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add connection management for H/2. This adds an abstraction and a default implementation for managing (reusing) HTTP/2 connections across requests.
The keep alive logic is similar to the ones found in other connect implementations and exposes similar options to tweak the behavior.
Unfortunately this also introduces a minor breaking change for users using H/2 with TLS, they will have to pass the security context in a slightly different way:
Not super happy with the name
Http2ClientTransportas we useTransportfor protocols.