This repository was archived by the owner on Dec 21, 2023. It is now read-only.
copy zookeeper dataDir to confluent_current #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is important when the user is starting zookeeper in replicated mode — zookeeper expects a user-created file called `myid` to exist in the dataDir
cyrusv
reviewed
May 23, 2018
| @@ -347,6 +347,11 @@ start_zookeeper() { | |||
|
|
|||
| config_zookeeper() { | |||
| config_service "zookeeper" "kafka" "zookeeper" "dataDir" | |||
|
|
|||
| # copy the contents of `dataDir` to the working confluent zookeeper data directory | |||
There was a problem hiding this comment.
Would be helpful to know "why" instead of "what" in the comment here
ctan888
pushed a commit
that referenced
this pull request
Feb 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
confluent transforms the zookeeper
dataDirproperty to point to a confluent-created working directory. this is fine in zookeeper standalone mode (the default), because this directory is only used during runtime to store snapshots and a log.In replicated mode, however, zookeeper expects a user-created file called
myidto exist.This PR rsyncs the contents of zookeeper's user-configured dataDir to confluent's working dir.
Fixes #46
cc @windman83