voting: Abstaining should be able to trigger early end

[uint]

In some scenarios an Abstain vote should trigger an early pass, but currently won't.

There's a test for this that's currently failing.

Also please check if this affects cw3-flex-multisig, oc-proposals, etc. It probably does.

[maurolacy]

This is a nice marginal issue you found. I wonder if the same couldn't / wouldn't happen with any votes (including no, veto). They both affect the total. They wouldn't impact the total weight used before expiration, but they can change the quorum.

Perhaps the best / simple solution here is to just update status after any vote is cast, independently of type.

[maurolacy]

Perhaps the best / simple solution here is to just update status after any vote is cast, independently of type.

voting-contract vote() already does exactly that. So, it's a matter of fixing this in the multisig contracts that do not leverage voting-contract yet (or port them to use voting-contract).

[uint]

I was wrong! The only bug was in my test. Fixed now. The logic is sound. Abstaining can close early. Closing.

[maurolacy]

Still, we need to address this issue of status changes after voting / expiration in "upstream" (i.e. old) cw3 contracts, and contracts that don't use voting-contract. Will create a couple issues in cw-plus for tracking this.

Update: CosmWasm/cw-plus#630.