docs(contributing): switch to rattler-build on Contributing packages page
#2558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucascolley
commented
Jul 7, 2025
✅ Deploy Preview for conda-forge-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
lucascolley
force-pushed
the
rattler-build
branch
3 times, most recently
from
be47d72 to
545b5ae
Compare
lucascolley
force-pushed
the
rattler-build
branch
from
545b5ae to
3cb627d
Compare
lucascolley
commented
Jul 7, 2025
Comment on lines
-583
to
+550
| <a id="testing-python-packages"></a> | ||
| <!-- <a id="testing-python-packages"></a> |
There was a problem hiding this comment.
DNM: the whole testing section has a lot of overlap with https://rattler.build/latest/reference/recipe_file/#tests-section and https://rattler.build/latest/testing/, advice appreciated on what should stay vs what we can just link out to.
Hofer-Julian
approved these changes
Jul 7, 2025
| @@ -865,7 +832,7 @@ the package – thus, at this point it does not have access to the original sour | |||
| tarball. This is to ensure that the test environment is as close as possible to | |||
| what an end-user will see. | |||
|
|
|||
| This makes it very hard to run tests that are not installed with the package. | |||
| This makes it very hard to run tests that are not installed with the package. --> | |||
There was a problem hiding this comment.
see #2558 (comment), my IDE makes these comments a lot more obvious than the GitHub UI 😅
|
not sure how to appease pre-commit in CI, will fix the broken anchors once we have finalised which sections are staying |
|
Looks like you need: PRETTIER_LEGACY_CLI=1 pre-commit run --all-files |
|
thanks @chrisburr :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist:
docs/orcommunity/, you have added it to the sidebar in the corresponding_sidebar.jsonfileWIP