Skip to content

Add outputs for jupytercad - #1567

Merged
h-vetinari merged 4 commits into
conda-forge:mainfrom
arjxn-py:add_jupytercad_outputs
Jun 27, 2025
Merged

Add outputs for jupytercad#1567
h-vetinari merged 4 commits into
conda-forge:mainfrom
arjxn-py:add_jupytercad_outputs

Conversation

@arjxn-py

Copy link
Copy Markdown
Member

@arjxn-py
arjxn-py requested a review from a team as a code owner June 19, 2025 13:45

@martinRenou martinRenou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SylvainCorlay

Copy link
Copy Markdown
Member

This looks sensible, but I have never worked on the output mapping.

@martinRenou

Copy link
Copy Markdown
Member

It's merely saying any package respecting the pattern jupytercad* can be uploaded from the jupytercad feedstock.

It will allow us renaming the packages from e.g. jupytercad_core to jupytercad-core

@h-vetinari

Copy link
Copy Markdown
Member

Glob patterns should be used sparingly (c.f. #1554). It's better to be explicit, e.g. just add jupytercad-core or whatever handful of names you want to add. If you use the glob, and sometimes later you (or someone else!) end up needing another feedstock jupytercad-foo (e.g. some other component or downstream use-case), the glob will turn out to be wrong.

@martinRenou

Copy link
Copy Markdown
Member

Are you saying that using jupytercad-* will prevent other feedstocks to publish packages with this pattern ?

@h-vetinari

Copy link
Copy Markdown
Member

Are you saying that using jupytercad-* will prevent other feedstocks to publish packages with this pattern ?

It will not prevent publication of matching packages on other feedstocks, but it will mean the jupytercad feedstock will have the right to publish jupytercad-foo, even after the creation of a jupytercad-foo feedstock (and then the jupytercad-feedstock shouldn't have that right anymore).

Comment thread requests/jupytercad-add-outputs.yml Outdated
Co-authored-by: martinRenou <martin.renou@gmail.com>
@martinRenou

Copy link
Copy Markdown
Member

@h-vetinari would you kindly review again?

Comment thread requests/jupytercad-add-outputs.yml Outdated
Comment thread requests/jupytercad-add-outputs.yml Outdated
Co-authored-by: Mark Harfouche <mark.harfouche@gmail.com>
@h-vetinari
h-vetinari merged commit 6ae12db into conda-forge:main Jun 27, 2025
@h-vetinari

h-vetinari commented Jun 27, 2025

Copy link
Copy Markdown
Member

@h-vetinari would you kindly review again?

Sorry for the delay, I'm listening to *all* notifications from this repo, but in turn that sometimes means I don't see things directly addressed to me right away.

@martinRenou

Copy link
Copy Markdown
Member

No worries at all, thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants