#182 Valid check_min_cppstd #184
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
jgsogo
suggested changes
Apr 28, 2020
Contributor
jgsogo
left a comment
jgsogo
left a comment
There was a problem hiding this comment.
Probably this hook is too fragile. IMO the cppstd issue is something to fix in the CI itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #182
#KB-H046: "VALIDATE CHECK_MIN_CPPSTD"
The method
tools.check_min_cppstduses the default c++ standard supported by the compiler, whensettings.compiler.cppstdis not defined. However, is can cause false-positives when a compiler supports a determined c++ standard.