Skip to content

Make diff symbols in conan report diff ... -f=html non selectable #19375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
memsharded merged 1 commit into from
Dec 10, 2025
Merged

Make diff symbols in conan report diff ... -f=html non selectable #19375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions conan/cli/formatters/report/diff_html.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,6 +463,12 @@
height: auto;
}

.diff-symbol {
display: inline-block;
width: 1ch;
user-select: none;
}

/* --- Utility & Page States --- */

#empty_result {
Expand Down Expand Up @@ -539,8 +545,12 @@
old_line_index = lineNumbers[0];
new_line_index = lineNumbers[1];
} else if (line.startsWith("+")) {
const spanSymbol = document.createElement("span");
spanSymbol.textContent = "+";
spanSymbol.className = "diff-symbol";
spanLine.className = "add";
spanLine.textContent = line;
spanLine.textContent = line.substring(1);
spanLine.prepend(spanSymbol);

const lineNumberSpan = document.createElement("span");
lineNumberSpan.className = "line-number add";
Expand All @@ -550,8 +560,12 @@
new_line_index += 1;
new_line_count += 1;
} else if (line.startsWith("-")) {
const spanSymbol = document.createElement("span");
spanSymbol.textContent = "-";
spanSymbol.className = "diff-symbol";
spanLine.className = "del";
spanLine.textContent = line;
spanLine.textContent = line.substring(1);
spanLine.prepend(spanSymbol);

const lineNumberSpan = document.createElement("span");
lineNumberSpan.className = "line-number del";
Expand All @@ -568,7 +582,10 @@
headerDiv.appendChild(document.createElement("br"));
continue;
} else {
const spanSymbol = document.createElement("span");
spanSymbol.className = "diff-symbol";
spanLine.textContent = line;
spanLine.prepend(spanSymbol);
}

const lineNumberSpan = document.createElement("span");
Expand Down
Loading