fix sysroot for qnx under autotools #18897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicosmd
reviewed
Sep 8, 2025
| if sysroot: | ||
| root = sysroot.replace("\\", "/") | ||
| compiler = self._conanfile.settings.get_safe("compiler") | ||
| self.sysroot_flag = f"--sysroot {root}" if compiler != "qcc" else f"-Wc,-isysroot {root}" |
Contributor
There was a problem hiding this comment.
I think the correct syntax is "-Wc,-isysroot,{root}". At least then the configuration went through and this is also how CMake passes the sysroot to qcc.
Member
Author
There was a problem hiding this comment.
Good point, thanks for checking it, I overlooked that detail, I'll fix it.
franramirez688
approved these changes
Dec 12, 2025
memsharded
added a commit
that referenced
this pull request
Dec 15, 2025
* fix sysroot for qnx under autotools * fix comma
czoido
added a commit
that referenced
this pull request
Dec 16, 2025
* wip * working * removed vxworks test * fixes * fix sysroot for qnx under autotools (#18897) * fix sysroot for qnx under autotools * fix comma * Feature/config install pkg lock (#17793) * conan config install-pkg from lockfile * checking locked config-requires * wip * wip * wip * minor refactor * wip * wip * fixes * reverted to not break existing cache config_version.json * fix test * wip * wip * wip * wip * final proposal * imports * ready for review * review, better API, better UX default to cwd, new command * fix test * fix ignore of conaninfo.txt and conanmanifest.txt * msg for conan config clean * [MesonToolchain] `needs_exe_wrapper` depends on `can_run` function (#19382) * Conditioned to can_run property * comments * without quotes * Fixed test * precedence * wip * wip * fixes * fixes * fixes * fixes * fixes * Update test/functional/toolchains/gnu/autotools/test_win_bash.py Co-authored-by: Carlos Zoido <[email protected]> --------- Co-authored-by: Francisco Ramírez <[email protected]> Co-authored-by: Carlos Zoido <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Avoid
AutotoolsToolchain/GnuToolchainto define--sysrootfor QNXqcccompiler, define-Wc,-isysrootinstead.Docs: Omit
Close #18890