investigating consumer flags per compiler #18727
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
1 task
memsharded
commented
Aug 27, 2025
Member
Author
|
A ConanCenter recipe would look like: #if is_msvc(self):
# Required for the __cplusplus check at
# https://github.com/DCMTK/dcmtk/blob/DCMTK-3.6.8/config/include/dcmtk/config/osconfig.h.in#L1489
# self.cpp_info.components[target_lib].cxxflags.append("/Zc:__cplusplus")
def myflags(consumer):
if consumer.settings.get_safe("compiler") == "msvc":
return ["/Zc:__cplusplus"]
self.cpp_info.components[target_lib].cxxflags = myflags |
Member
Author
|
With new changes, the recipe in ConanCenter could be just: self.cpp_info.cxxflags = lambda c: ["/Zc:__cplusplus"] if is_msvc(c) else []And fully transparent to the consumers |
memsharded
commented
Nov 5, 2025
…in both contexts with different settings (conan-io#19208) * Add failing test for compat when different context reuires different packages potential path forward What? Maybe simplify test make test valid in windows too Bump version * This also fails with update * fixes * fixes * Simplify --------- Co-authored-by: memsharded <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: (Feature | Fix | Bugfix): Describe here your pull request
Docs: https://github.com/conan-io/docs/pull/XXXX
Close #18613