Skip to content
This repository was archived by the owner on Jan 12, 2022. It is now read-only.

refactor dotenv parser in order to support multi-line variable values declaration#2

Merged
ndeloof merged 2 commits into
compose-spec:masterfrom
x1unix:feat/value-separator
Sep 24, 2021
Merged

refactor dotenv parser in order to support multi-line variable values declaration#2
ndeloof merged 2 commits into
compose-spec:masterfrom
x1unix:feat/value-separator

Conversation

@ndeloof

@ndeloof ndeloof commented Sep 23, 2021

Copy link
Copy Markdown
Collaborator

This is a clone PR for joho#118

@ndeloof

ndeloof commented Sep 23, 2021

Copy link
Copy Markdown
Collaborator Author

@x1unix sorry to bother you with this, we'd like to adopt your PR for compose support of dotEnv file, but our oss contribution policy require all commits to be signed-off (git -s).
Would you mind amending your value-separator branch for this? 🙏

… declaration

Signed-off-by: x1unix <denis0051@gmail.com>
Signed-off-by: x1unix <denis0051@gmail.com>
@x1unix x1unix force-pushed the feat/value-separator branch from acd8c1e to 993ff7a Compare September 23, 2021 21:22
@x1unix

x1unix commented Sep 23, 2021

Copy link
Copy Markdown

@ndeloof done

@x1unix

x1unix commented Sep 23, 2021

Copy link
Copy Markdown

@ndeloof can I contribute any additional fixes directly to this repo? A few projects on my job also depend on my hotfix and there is no ETA when PR will be merged into upstream.

Also, I've changed import url on master branch of the fork and included multi-line hotfix there, so you can also use my fork (version v1.4.0).

go get -u github.com/x1unix/godotenv@v1.4.0

@ndeloof

ndeloof commented Sep 24, 2021

Copy link
Copy Markdown
Collaborator Author

@x1unix sure, you can contribute additional fixes, as long as you feel those are relevant in the context of .env support in docker compose (or related) projects.
Please notice we have only kept the "parser" in this repo, as this is not expected to be used as a command line.

@ndeloof ndeloof merged commit 934be71 into compose-spec:master Sep 24, 2021
@x1unix x1unix deleted the feat/value-separator branch February 7, 2023 00:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants