Skip to content

Remove redundant wasm interpreter class #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

anutosh491
Copy link
Collaborator

Description

The reason behind this PR has been explained in the issue description.

Fixes #369

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Added/removed dependencies
  • Required documentation updates

@anutosh491 anutosh491 force-pushed the remove-wasm-interpreter branch from 614bf8b to ec379e3 Compare August 12, 2025 06:49
@anutosh491 anutosh491 requested a review from vgvassilev August 12, 2025 06:55
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.78%. Comparing base (fd6edbd) to head (ec379e3).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #370   +/-   ##
=======================================
  Coverage   81.78%   81.78%           
=======================================
  Files          20       20           
  Lines         950      950           
  Branches       87       87           
=======================================
  Hits          777      777           
  Misses        173      173           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- always feels good to do the same amount of work with less code...

@anutosh491
Copy link
Collaborator Author

anutosh491 commented Aug 12, 2025

always feels good to do the same amount of work with less code...

Yes, exactly my intention here :)

Thanks.

@anutosh491 anutosh491 merged commit 35385c3 into compiler-research:main Aug 12, 2025
17 checks passed
@anutosh491 anutosh491 deleted the remove-wasm-interpreter branch August 12, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redundant wasm interpreter class ?
3 participants