Skip to content

[cmake] Perform symbol exports depending on winx86 and winx64 #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

aaronj0
Copy link
Collaborator

@aaronj0 aaronj0 commented Jan 16, 2025

Fixes issues building libCling and unit tests on ROOT for winx86

@aaronj0 aaronj0 force-pushed the win-symbol-exports branch from e7ebcc4 to df0e87d Compare January 16, 2025 18:04
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.96%. Comparing base (a6976c0) to head (df0e87d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #455   +/-   ##
=======================================
  Coverage   70.96%   70.96%           
=======================================
  Files           9        9           
  Lines        3541     3541           
=======================================
  Hits         2513     2513           
  Misses       1028     1028           

@aaronj0 aaronj0 requested a review from vgvassilev January 16, 2025 19:13
Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aaronj0 aaronj0 merged commit 04f45b2 into compiler-research:main Jan 16, 2025
45 checks passed
@aaronj0 aaronj0 deleted the win-symbol-exports branch April 22, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants