Refactoring the API for multiple interpreter instance support #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Gnimuc
force-pushed
the
c-api-refactor
branch
from
5c64f77 to
0cf2bf1
Compare
Gnimuc
commented
Oct 27, 2024
| void Destruct(TCppObject_t This, TCppScope_t scope, bool withFree /*=true*/) { | ||
| Decl* Class = (Decl*)scope; | ||
| if (auto wrapper = make_dtor_wrapper(getInterp(), Class)) { | ||
| TCppObject_t Construct(TCppScope_t scope, void* arena /*=nullptr*/) { |
There was a problem hiding this comment.
also removed the Impl suffix.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #338 +/- ##
==========================================
+ Coverage 74.29% 74.43% +0.14%
==========================================
Files 8 8
Lines 3190 3204 +14
==========================================
+ Hits 2370 2385 +15
+ Misses 820 819 -1
... and 1 file with indirect coverage changes
|
Gnimuc
force-pushed
the
c-api-refactor
branch
from
fedb10d to
92ab4c7
Compare
vgvassilev
reviewed
Oct 27, 2024
Gnimuc
force-pushed
the
c-api-refactor
branch
from
9d76fcc to
4ec28eb
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
approved these changes
Oct 27, 2024
|
Can you squash the commits to have clear history? |
also fix argument type typos and c-style casts
Gnimuc
force-pushed
the
c-api-refactor
branch
from
4ec28eb to
9acb9e8
Compare
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel like we also need to split the implementation and use an internal shared header for interfaces.