Use nodemailer for sending email (with local email dev solution) #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
July 17, 2020 14:29
…ransport mechanisms.
|
Hm. Worked locally, but something happening when running on GitHub Actions, and cy.visit is getting confused... Will investigate later. |
|
Realized that config should implicitly test the mail transport failover, so AWS and Mailgun should be set as higher priority, with maildev at end. Then, if email shows in maildev UI, falilover transports worked |
|
For later, apparently maildev has a restful API, so we can be hitting that instead of parsing an html page, as recommended by cypress best-practices. https://github.com/maildev/maildev/blob/master/docs/rest.md |
|
Thanks so much for the review @ballPointPenguin! Good call on figuring out migrations. I'll do that in this PR then bring it out of draft |
|
This is now |
patcon
commented
Aug 21, 2020
patcon
commented
Aug 21, 2020
|
Hm. Not sure why e2e tests aren't running... seems to have stopped in cca71ac |
patcon
commented
Aug 21, 2020
patcon
commented
Aug 22, 2020
raulsperoni
pushed a commit
to proyectourgente/polis
that referenced
this pull request
Sep 1, 2021
…pdemocracy#433) * Updated database schema to bugfix password reset process. [Fixes compdemocracy#273] * Added maildev docker container for inspecting emails during dev. * Ensured the proxied services are seeing the origin host. * Small fixup from rebase. * Added SMTP port exposure to maildev container. * Migrated AWS_REGION config into envvar. * Added mailgun nodemailer transport. Added fallback through multiple transport mechanisms. * Added ability for cypress to check maildev inbox on another port. * e2e: Fixed create_user test. * e2e: Added checks of password reset flow. * e2e: Added test stubs for types of emails sent. * e2e: Run through whole password reset flow, and confirm new password. * e2e: Added plugin to output more details to stdout. * e2e: Make more clear when reporter prints to terminal. * Added log command for troubleshooting GitHub Actions issue. * e2e: Fixed issue with matching password reset token. * Added testing of email transport failover. * Adding docs for email transport configuration. [skip ci] * Check maildev via API instead of UI. * Improved documentation of cypress workflow for email transports. * e2e: Added note about cypress-terminal-report in README. * Removed straggling TODO. * Set email transport defaults to match current production.
raulsperoni
pushed a commit
to proyectourgente/polis
that referenced
this pull request
Oct 26, 2021
…pdemocracy#433) * Updated database schema to bugfix password reset process. [Fixes compdemocracy#273] * Added maildev docker container for inspecting emails during dev. * Ensured the proxied services are seeing the origin host. * Small fixup from rebase. * Added SMTP port exposure to maildev container. * Migrated AWS_REGION config into envvar. * Added mailgun nodemailer transport. Added fallback through multiple transport mechanisms. * Added ability for cypress to check maildev inbox on another port. * e2e: Fixed create_user test. * e2e: Added checks of password reset flow. * e2e: Added test stubs for types of emails sent. * e2e: Run through whole password reset flow, and confirm new password. * e2e: Added plugin to output more details to stdout. * e2e: Make more clear when reporter prints to terminal. * Added log command for troubleshooting GitHub Actions issue. * e2e: Fixed issue with matching password reset token. * Added testing of email transport failover. * Adding docs for email transport configuration. [skip ci] * Check maildev via API instead of UI. * Improved documentation of cypress workflow for email transports. * e2e: Added note about cypress-terminal-report in README. * Removed straggling TODO. * Set email transport defaults to match current production.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #231
Should be working, but need to write tests before I seek full review. But I'm still looking for feedback on the approach I've taken :)
To Do
fix issue withmoved to Add support for proper database migrations (fix pwreset table) #542pwreset_tokensdatabase table being named improperlyother e2e tests to consider adding in future:
broken(see: Conversation data export not working via UI #39)