Skip to content

[core]: Feature - Check Quorum Status in create_lxc to prevent issues #5278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025

Conversation

MickLesk
Copy link
Member

@MickLesk MickLesk commented Jun 19, 2025

✍️ Description

In a Proxmox VE cluster, it is not allowed to make changes to the cluster configuration (such as creating a CT or VM) if the cluster is not “quorate”. This means: If the cluster does not reach a quorum (e.g. with a 2-node cluster and only one node is online), actions such as pct create, qm create, etc. are not allowed - even if you are directly on the working node.

In the same stage, i move "create_lxc" from ct-Folder to misc-Folder

Related to this:
=> #5245

if an cluster (node) is offline, create_lxc failed, because proxmox need an quorum for clusters.
[ERROR] in line 1127 #5169
=> User-Feedback: #5169 (comment)

Output:
image

🔗 Related PR / Issue

Link: #5169 #5245

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

@MickLesk MickLesk requested a review from a team as a code owner June 19, 2025 11:08
@github-actions github-actions bot added core github high risk A change that can affect many scripts maintenance Code maintenance or general upkeep of the project labels Jun 19, 2025
@MickLesk MickLesk added feature and removed maintenance Code maintenance or general upkeep of the project high risk A change that can affect many scripts github labels Jun 19, 2025
@github-actions github-actions bot added github high risk A change that can affect many scripts maintenance Code maintenance or general upkeep of the project labels Jun 19, 2025
@MickLesk MickLesk removed maintenance Code maintenance or general upkeep of the project high risk A change that can affect many scripts github labels Jun 19, 2025
@MickLesk MickLesk merged commit b5012c4 into main Jun 19, 2025
3 checks passed
@MickLesk MickLesk added the maintenance Code maintenance or general upkeep of the project label Jun 19, 2025
@MickLesk MickLesk deleted the feature_create_lxc_quorum_status branch June 20, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core feature maintenance Code maintenance or general upkeep of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants