Skip to content

WSL2 clarification #1567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 12, 2021
Merged

WSL2 clarification #1567

merged 3 commits into from
Nov 12, 2021

Conversation

mr-c
Copy link
Member

@mr-c mr-c commented Nov 12, 2021

No description provided.

@mr-c mr-c requested a review from ALuesink November 12, 2021 09:53
@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #1567 (6e44d8b) into main (0209b0b) will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1567      +/-   ##
==========================================
- Coverage   66.09%   65.93%   -0.16%     
==========================================
  Files          91       91              
  Lines       16299    16299              
  Branches     4222     4222              
==========================================
- Hits        10773    10747      -26     
- Misses       4379     4400      +21     
- Partials     1147     1152       +5     
Impacted Files Coverage Δ
update.py 56.86% <0.00%> (-5.89%) ⬇️
checker.py 84.61% <0.00%> (-3.42%) ⬇️
load_tool.py 53.60% <0.00%> (-0.91%) ⬇️
docker.py 48.90% <0.00%> (-0.88%) ⬇️
utils.py 74.16% <0.00%> (-0.74%) ⬇️
job.py 62.06% <0.00%> (-0.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0209b0b...6e44d8b. Read the comment docs.

Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clicked on "View File" here on GitHub, and the rendered output looks a bit odd, but maybe because it's in the PR?

image

Text looks good though!

@ALuesink
Copy link
Contributor

Similar to @kinow, I'm not sure if the image will show or if it remains a link. Otherwise it looks good.

@mr-c mr-c enabled auto-merge (squash) November 12, 2021 15:54
@mr-c mr-c merged commit 352daf6 into main Nov 12, 2021
@mr-c mr-c deleted the wsl2_clarification branch November 12, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants