Skip to content

Check python3 #1478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 16, 2021
Merged

Check python3 #1478

merged 4 commits into from
Aug 16, 2021

Conversation

tetron
Copy link
Member

@tetron tetron commented Aug 5, 2021

"make release-test" tweaks.

Check that "python" is actually python 3. Also add "pip install -e ." before running tests on HEAD.

@mr-c mr-c enabled auto-merge (squash) August 5, 2021 14:22
@mr-c mr-c disabled auto-merge August 5, 2021 14:22
@mr-c mr-c enabled auto-merge (rebase) August 5, 2021 14:22
@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #1478 (6d2ded3) into main (5883109) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1478      +/-   ##
==========================================
+ Coverage   65.74%   65.76%   +0.01%     
==========================================
  Files          89       89              
  Lines       15628    15628              
  Branches     3933     3933              
==========================================
+ Hits        10275    10277       +2     
+ Misses       4262     4260       -2     
  Partials     1091     1091              
Impacted Files Coverage Δ
cwltool/job.py 77.62% <0.00%> (-0.41%) ⬇️
job.py 62.22% <0.00%> (+0.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5883109...6d2ded3. Read the comment docs.

@mr-c mr-c disabled auto-merge August 5, 2021 15:36
@mr-c mr-c enabled auto-merge (squash) August 5, 2021 15:37
@mr-c mr-c disabled auto-merge August 5, 2021 15:38
@tetron
Copy link
Member Author

tetron commented Aug 5, 2021

I really don't understand why these tests are failing.

@tetron
Copy link
Member Author

tetron commented Aug 5, 2021

Seems like this might be detecting a legitimate bug, but I don't yet know why the test passes in some environments and fails in other environments.

@tetron
Copy link
Member Author

tetron commented Aug 5, 2021

So this is definitely failing due to an underlying bug which is probably the same one described in #1364

The problem is when moving a directory containing a symlink to another file in the temp directory, it doesn't update the symlink to point to the new location.

I don't understand why it is happening on this branch when (a) the changes are so trivial (b) I can't reproduce it except by changing the code to skip a step which mitigates the crash (but not the underlying error).

I either way, I will extend the test to check for expected behavior more thoroughly, and then fix the underlying bug.

@mr-c mr-c enabled auto-merge (squash) August 16, 2021 10:56
@mr-c mr-c merged commit fa46c0a into main Aug 16, 2021
@mr-c mr-c deleted the check-python3 branch August 16, 2021 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants