Skip to content

Conversation

LanderOtto
Copy link
Contributor

@LanderOtto LanderOtto commented Jun 14, 2025

Added tests on default value

@LanderOtto LanderOtto force-pushed the scatter-valuefrom-default branch from a848dbd to 2d0b28b Compare June 14, 2025 07:39
@GlassOfWhiskey GlassOfWhiskey requested a review from mr-c June 14, 2025 08:01
@LanderOtto LanderOtto marked this pull request as draft June 14, 2025 09:48
@mr-c mr-c force-pushed the scatter-valuefrom-default branch from 2d0b28b to 6ff1ef2 Compare June 14, 2025 11:11
@mr-c
Copy link
Member

mr-c commented Sep 1, 2025

Hello @LanderOtto ; is your PR ready for me to merge it?

@LanderOtto LanderOtto force-pushed the scatter-valuefrom-default branch from 892da7e to 3a8250c Compare September 2, 2025 13:15
@LanderOtto LanderOtto force-pushed the scatter-valuefrom-default branch from 3a8250c to 7091ec3 Compare September 2, 2025 13:19
@LanderOtto
Copy link
Contributor Author

Yes, I added two additional tests related to default values. One test covers the case where the default is a StepInput used in a loop with a valueFrom directive. The other test involves a step with three inputs: one is used for the scatter operation, while the other two rely on their default values and are not explicitly passed.

@LanderOtto LanderOtto marked this pull request as ready for review September 2, 2025 13:22
@LanderOtto LanderOtto changed the title Added test using valueFrom and default inside a scatter Added test on default values Sep 2, 2025
@LanderOtto LanderOtto changed the title Added test on default values Added tests on default value Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants