Does not work after npm i and package config

[maboiteaspam]

Hi!

TLDR; IRFM, ran it, then tried to run git cz, it failed with an unfortunate but epic error,

D:\work\MyBlog\C\c2-bin>git cz
module.js:338
    throw err;
          ^
Error: Cannot find module 'D:\work\MyBlog\C\c2-bin\node_modules\commitizen\bin\git-cz'
    at Function.Module._resolveFilename (module.js:336:15)
    at Function.Module._load (module.js:278:25)
    at Function.Module.runMain (module.js:501:10)
    at startup (node.js:129:16)
    at node.js:814:3

The longer story

Running windows 7 with node and npm such

D:\work\MyBlog\C\c2-bin>npm -v
2.11.3

D:\work\MyBlog\C\c2-bin>node -v
v0.12.7

I have run D:\work\MyBlog\C\c2-bin>npm install -g commitizen,
then D:\work\MyBlog\C\c2-bin>commitizen init cz-conventional-changelog --save --save-exact

Then i configured my local package.json file to add

  ,"config": {
    "commitizen": {
      "path": "node_modules/cz-conventional-changelog"
    }
  }

Where did i get it wrong ?

Thanks !

D:\work\MyBlog\C\c2-bin>commitizen init cz-conventional-changelog --save --save-exact
Attempting to initialize using the npm package cz-conventional-changelog
Error: A previous adapter is already configured. Use --force to override

D:\work\MyBlog\C\c2-bin>commitizen init cz-conventional-changelog --save --save-exact --force
Attempting to initialize using the npm package cz-conventional-changelog
npm WARN using --force I sure hope you know what you are doing.
npm WARN package.json c2-bin@1.0.0 No repository field.
npm WARN package.json c2-bin@1.0.0 license should be a valid SPDX license expression
cz-conventional-changelog@1.1.4 node_modules\cz-conventional-changelog
└── word-wrap@1.1.0
{this.config was unexpected at this time.

D:\work\MyBlog\C\c2-bin>  "C:\Users\d1m\AppData\Roaming\npm\node_modules\commitizen\node_modules\.bin\\node.exe"  "C:\Users\d1m\AppData\Roaming\npm\node_modules\commitizen\node
_modules\.bin\\..\json\lib\json.js" -I -f D:\work\MyBlog\C\c2-bin\package.json -e 'if(!this.config) {this.config={};}; if(!this.config.commitizen) { this.config.commitizen={};}
; this.config.commitizen.path="./node_modules/cz-conventional-changelog"'

D:\work\MyBlog\C\c2-bin>git cz
module.js:338
    throw err;
          ^
Error: Cannot find module 'D:\work\MyBlog\C\c2-bin\node_modules\commitizen\bin\git-cz'
    at Function.Module._resolveFilename (module.js:336:15)
    at Function.Module._load (module.js:278:25)
    at Function.Module.runMain (module.js:501:10)
    at startup (node.js:129:16)
    at node.js:814:3

D:\work\MyBlog\C\c2-bin>

[jimthedev]

Hi! Sorry to hear you're having trouble. Can you try using a this in your package.json?

  ,"config": {
    "commitizen": {
      "path": "./node_modules/cz-conventional-changelog"
    }
  }

[maboiteaspam]

How about having a console argument for the matter of that value ?

I have a case where i want to run same cz for many instances, i don t feel like i want to duplicate it everywhere. That seems inappropriate to me.

I ve gone through your sources, and find quickly you are not using any helper for that.
Any matter here ?

  // Get cli args
  let rawGitArgs = process.argv.slice(2, process.argv.length);

This said, i ran into similar issue on my box too,

maboiteaspam [21:12:08] c2-bin (master) # npm install -g commitizen
npm WARN optional dep failed, continuing fsevents@1.0.2
npm WARN optional dep failed, continuing fsevents@1.0.2
/home/maboiteaspam/bin/git-cz -> /home/maboiteaspam/lib/node_modules/commitizen/bin/git-cz
/home/maboiteaspam/bin/commitizen -> /home/maboiteaspam/lib/node_modules/commitizen/bin/commitizen
commitizen@2.3.0 /home/maboiteaspam/lib/node_modules/commitizen
├── dedent@0.4.0
├── strip-json-comments@1.0.4
├── rimraf@2.4.3
├── node-uuid@1.4.3
├── minimist@1.2.0
├── semver@5.0.3
├── cz-conventional-changelog@1.1.4 (word-wrap@1.1.0)
├── shelljs@0.5.3
├── chalk@1.1.1 (escape-string-regexp@1.0.3, supports-color@2.0.0, ansi-styles@2.1.0, has-ansi@2.0.0, strip-ansi@3.0.0)
├── json@9.0.3
├── inquirer@0.10.1 (strip-ansi@3.0.0, ansi-regex@2.0.0, ansi-escapes@1.1.0, cli-width@1.1.0, figures@1.4.0, through@2.3.8, rx-lite@3.1.2, lodash@3.10.1, run-async@0.1.0, cli-cursor@1.0.2, readline2@1.0.1)
├── glob@5.0.15 (path-is-absolute@1.0.0, inherits@2.0.1, inflight@1.0.4, once@1.3.2, minimatch@3.0.0)
├── find-node-modules@1.0.1 (merge@1.2.0, findup-sync@0.2.1)
├── nodemon@1.7.3 (undefsafe@0.0.3, es6-promise@3.0.2, minimatch@3.0.0, touch@1.0.0, debug@2.2.0, lodash.defaults@3.1.2, ps-tree@1.0.1, chokidar@1.2.0, update-notifier@0.5.0)
├── gulp-git@1.6.0 (any-shell-escape@0.1.1, require-dir@0.1.0, through2@0.6.5, gulp-util@3.0.7)
├── gulp@3.9.0 (interpret@0.6.6, pretty-hrtime@1.0.1, deprecated@0.0.1, archy@1.0.0, tildify@1.1.2, v8flags@2.0.10, semver@4.3.6, orchestrator@0.3.7, liftoff@2.2.0, vinyl-fs@0.3.14, gulp-util@3.0.7)
└── babel@5.8.23 (path-is-absolute@1.0.0, slash@1.0.0, path-exists@1.0.0, fs-readdir-recursive@0.1.2, convert-source-map@1.1.1, commander@2.9.0, source-map@0.4.4, output-file-sync@1.1.1, lodash@3.10.1, chokidar@1.2.0, babel-core@5.8.29)
maboiteaspam [21:15:12] c2-bin (master) # commitizen init cz-conventional-changelog --save --save-exact
Attempting to initialize using the npm package cz-conventional-changelog
Error: A previous adapter is already configured. Use --force to override
maboiteaspam [21:26:33] c2-bin (master) # git cz
/home/maboiteaspam/lib/node_modules/commitizen/src/commitizen/adapter.js:162
    throw err;
          ^
Error: ENOENT, no such file or directory '/home/maboiteaspam/Bureau/C/c2-bin/node_modules/cz-conventional-changelog'
    at Error (native)
    at Object.fs.lstatSync (fs.js:792:18)
    at resolveAdapterPath (/home/maboiteaspam/lib/node_modules/commitizen/src/commitizen/adapter.js:115:11)
    at getPrompter (/home/maboiteaspam/lib/node_modules/commitizen/src/commitizen/adapter.js:92:29)
    at gitCz (/home/maboiteaspam/lib/node_modules/commitizen/src/cli/strategies/git-cz.js:48:20)
    at Object.bootstrap (/home/maboiteaspam/lib/node_modules/commitizen/src/cli/git-cz.js:24:5)
    at Object.<anonymous> (/home/maboiteaspam/lib/node_modules/commitizen/bin/git-cz.js:3:33)
    at Module._compile (module.js:460:26)
    at normalLoader (/home/maboiteaspam/lib/node_modules/commitizen/node_modules/babel/node_modules/babel-core/lib/api/register/node.js:199:5)
    at Object.require.extensions.(anonymous function) [as .js] (/home/maboiteaspam/lib/node_modules/commitizen/node_modules/babel/node_modules/babel-core/lib/api/register/node.js:216:7)
maboiteaspam [21:26:50] c2-bin (master) # npm install -g conventional-changelog^C
maboiteaspam [21:28:03] c2-bin (master) # ^C
maboiteaspam [21:28:03] c2-bin (master) # npm i cz-conventional-changelog
npm WARN package.json c2-bin@1.0.0 No repository field.
npm WARN package.json c2-bin@1.0.0 license should be a valid SPDX license expression
cz-conventional-changelog@1.1.4 node_modules/cz-conventional-changelog
└── word-wrap@1.1.0
maboiteaspam [21:28:19] c2-bin (master) # git cz
Error: No files added to staging! Did you forget to run git add?
maboiteaspam [21:29:46] c2-bin (master) # 

I suggest to improve the README.md to better indicate and suggest about the required first adapter,

npm i cz-conventional-changelog --save-dev --save-exact

I ll check again tomorrow on windows see.

[jimthedev]

Thank you for the feedback on the README. It does need to be updated to be more clear. I have opened #27 to track the documentation changes and will make sure to include our discussion.

Let's take a look at this lines in the error log you posted. This is an important error:

maboiteaspam [21:15:12] c2-bin (master) # commitizen init cz-conventional-changelog --save --save-exact
Attempting to initialize using the npm package cz-conventional-changelog
Error: A previous adapter is already configured. Use --force to override

You had previously configured an adapter but the path was wrong. This error is trying to inform you that commitizen init will not install a new adapter and edit your package.json if you have a path already configured.

In order to tell Commitizen that it is ok to override the previous value, you must re-run the command above with the --force flag. Running with the --force flag overwrites any previous value in the package.json's config.commitizen.path and runs npm install cz-conventional-changelog --save-dev --save-exact so that you do not need to do that manually.

So, the command would be:

commitizen init cz-conventional-changelog --save --save-exact --force

By running this, you should be all set.

[maboiteaspam]

ok, so i cleaned up my env here on windows, re ran,

commitizen init cz-conventional-changelog --save --save-exact

and got expected results. the new package, the new dependency.

So far, git cz, hangs, it s expected,

git cz
module.js:338
    throw err;
          ^
Error: Cannot find module 'D:\work\MyBlog\C\c2-bin\node_modules\commitizen\bin\git-cz'
    at Function.Module._resolveFilename (module.js:336:15)
    at Function.Module._load (module.js:278:25)
    at Function.Module.runMain (module.js:501:10)
    at startup (node.js:129:16)
    at node.js:814:3

Then update the package file such

{
  "name": "c2-bin",
  "version": "1.0.0",
  "description": "Command and Control binary for C projects.",
  "main": "index.js",
  "bin": {
    "c2-bin": "bin.js"
  },
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "keywords": [],
  "author": "maboitespam",
  "prefer": "global",
  "license": "WTF",
  "dependencies": {
    "chokidar": "^1.2.0",
    "findup-sync": "^0.3.0",
    "glob": "^5.0.15",
    "got": "^4.2.0",
    "grunt": "^0.4.5",
    "grunt-cli": "^0.1.13",
    "grunt-open": "^0.2.3",
    "inquirer": "^0.10.1",
    "minimist": "^1.2.0",
    "once": "^1.3.2",
    "resolve": "^1.1.6"
  },
  "devDependencies": {
    "cz-conventional-changelog": "^1.1.4"
  }
,"config": {
  "commitizen": {
    "path": "node_modules/cz-conventional-changelog"
  }
}
}

Still hang.

trying,

    "path": "./node_modules/cz-conventional-changelog"

same.

Also tried,

,"config": {
  "commitizen": {
    "path": ".\\node_modules\\cz-conventional-changelog"
  }

same.

I ve not gone through the source, but i d say it s missing a path.join according to the fact it worked on my linux box and this is about a stupid path resolution issue.

Still, i d like to know how you feel about passing this value as a cli parameter. if you feel not to add this, just let it know.

[maboiteaspam]

before i forget, again i really want to suggest about improving the README. Yesterday I really felt this one was hard to read. I d suggest to get something close to those examples https://github.com/substack/node-browserify https://github.com/rvagg/changelog-maker with some clear identified sections about some clearly identified steps (Install, Usage ect).

[jimthedev]

Did you try commitizen init cz-conventional-changelog --save --save-exact --force?

[jimthedev]

Also can you confirm that you have commitizen version 2.3.0 installed?

[jimthedev]

Hi there. Hope you aren't still having this problem but if you are, please provide some of the info above. If not I'll probably close it in 3 days. Obviously you can always reopen.

[maboiteaspam]

Hi!

Sorry for the lag, i got absorbed into other matters.

Yes! i do have 2.3.0

npm ls commitizen -g --depth=1
npm WARN unmet dependency C:\Users\d1m\AppData\Roaming\npm\node_modules\yeoman requires bower@'~0.3.0' but will load
npm WARN unmet dependency C:\Users\d1m\AppData\Roaming\npm\node_modules\bower,
npm WARN unmet dependency which is version 1.4.1
npm WARN unmet dependency C:\Users\d1m\AppData\Roaming\npm\node_modules\yeoman requires clean-css@'~0.3.2' but will load
npm WARN unmet dependency C:\Users\d1m\AppData\Roaming\npm\node_modules\clean-css,
npm WARN unmet dependency which is version 3.3.5
C:\Users\d1m\AppData\Roaming\npm
└── commitizen@2.3.0

Running
commitizen init cz-conventional-changelog --save --save-exact --force
outputs

D:\work\MyBlog\C\c2-bin>commitizen init cz-conventional-changelog --save --save-exact --force
Attempting to initialize using the npm package cz-conventional-changelog
npm WARN using --force I sure hope you know what you are doing.
npm WARN package.json c2-bin@1.0.0 No repository field.
npm WARN package.json c2-bin@1.0.0 license should be a valid SPDX license expression
cz-conventional-changelog@1.1.4 node_modules\cz-conventional-changelog
└── word-wrap@1.1.0
{this.config was unexpected at this time.

D:\work\MyBlog\C\c2-bin>  "C:\Users\d1m\AppData\Roaming\npm\node_modules\commitizen\node_modules\.bin\\node.exe"  "C:\Users\d1m\AppData\Roaming\npm\node_modules\commitize
n\node_modules\.bin\\..\json\lib\json.js" -I -f D:\work\MyBlog\C\c2-bin\package.json -e 'if(!this.config) {this.config={};}; if(!this.config.commitizen) { this.config.com
mitizen={};}; this.config.commitizen.path="./node_modules/cz-conventional-changelog"'

D:\work\MyBlog\C\c2-bin>

Then git cz

D:\work\MyBlog\C\c2-bin>git cz
module.js:338
    throw err;
          ^
Error: Cannot find module 'D:\work\MyBlog\C\c2-bin\node_modules\commitizen\bin\git-cz'
    at Function.Module._resolveFilename (module.js:336:15)
    at Function.Module._load (module.js:278:25)
    at Function.Module.runMain (module.js:501:10)
    at startup (node.js:129:16)
    at node.js:814:3

D:\work\MyBlog\C\c2-bin>

Does it help ?

[maboiteaspam]

And my package json is

{
  "name": "c2-bin",
  "version": "1.0.0",
  "description": "Command and Control binary for C projects.",
  "main": "index.js",
  "bin": {
    "c2-bin": "bin.js"
  },
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "keywords": [],
  "author": "maboitespam",
  "prefer": "global",
  "license": "WTF",
  "dependencies": {
    "chokidar": "^1.2.0",
    "findup-sync": "^0.3.0",
    "glob": "^5.0.15",
    "got": "^4.2.0",
    "grunt": "^0.4.5",
    "grunt-cli": "^0.1.13",
    "grunt-open": "^0.2.3",
    "inquirer": "^0.10.1",
    "minimist": "^1.2.0",
    "once": "^1.3.2",
    "resolve": "^1.1.6"
  },
  "devDependencies": {
    "cz-conventional-changelog": "^1.1.4"
  },
  "config": {
    "commitizen": {
      "path": ".\\node_modules\\cz-conventional-changelog"
    }
  }
}

BTW! How to do with this commitizen path, which is here windows format, but when i ll get back home, on linux, i will need to use a linux forward slashed path.
Can it the path format be lifted whatever is the os to make that work smoothly ?

[jimthedev]

@maboiteaspam I found the problem. All tests are now passing on windows and I swapped out the json editor which seemed to have problems on windows. This is a much simpler method of editing the json and seems to perform much better on windows. If this doesn't fix your problem then please let me know.