add snapshot diff previous link and time to snapshot date #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(the time may actually be when the snapshot build started)
|
Added %Z (timezone) to the time format |
|
Only add previous diff link if there is a previous previous snapshot |
|
Fix previous diff to use/be off previous snapshot |
chreekat
requested changes
Feb 3, 2025
|
Okay updated - still a bit ugly, but maybe the best we can do. I have a convention of prefixing Maybe variables with |
chreekat
approved these changes
Feb 3, 2025
allowing navigating back to earlier consecutive diffs Arguably we could also navigate name1 and name2 separately Thanks to @chreekat for reviewing and improving the code (commercialhaskell#340)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These 3 commits are unrelated but small and self-contained, so I thought easier to just combine in one PR:
github.com/fpco/withmygithub.libinneed.workers.dev/commercialhaskell/Compiles fine but untested (since I don't have a local db setup)