Skip to content

Fix binary version computation of Scala nightly versions #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 10, 2021

Conversation

adpi2
Copy link
Contributor

@adpi2 adpi2 commented Apr 7, 2021

Continuation of #1139

  • Add more test on Scala 3 nightly versions.
  • Fix isBinaryBridgeAvailable
  • Fix withDottyCompat

@lefou this is ready for review

@adpi2 adpi2 force-pushed the scala-nightlies-binary-version branch from 8344568 to 107b308 Compare April 7, 2021 13:30
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. For unknown reasons, the CI did not run... Could you push, rebase, or synchronize with master, to trigger another CI run?

@adpi2 adpi2 force-pushed the scala-nightlies-binary-version branch from 107b308 to 85074d5 Compare April 10, 2021 08:00
@lefou lefou merged commit b8f649a into com-lihaoyi:master Apr 10, 2021
@lefou lefou added this to the after 0.9.6 milestone Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants